search

rackspace-cookbooks / rackspacecloud

LWRPs for Rackspace Cloud APIs
Apache License 2.0
10 stars 17 forks source link

subdirectories supported in rackspacecloud_file #32

Closed lmunro closed 9 years ago

lmunro commented 9 years ago

Currently the rackspacecloud_file resource only supports downloading/uploading to the root of the container. This PR adds the ability to upload or download cloudfiles to/from a subdirectory within a container.

It is backwards compatible, so if the new filepath attribute is left blank the resource will operate in the same way it does now.

martinb3 commented 9 years ago

Made one comment about style, but it looks good to me. Feel free to merge or adjust. :+1:

lmunro commented 9 years ago

I started changing the attribute names to something more accurate however rolled back due to the lack of tests. Due to that I opted for the least disruptive change for now, and we can revisit this when we have more time for a comprehensive re-write with proper test coverage.

I've renamed "filepath" to "cloudfile_uri" for now so it doesn't clash/confuse with "filename"

jujugrrr commented 9 years ago

all good to me :+1: . :shipit: