Shock - Githubissues

radar / mtg

Magic: The Gathering, but in Ruby

63 stars 11 forks source link

Shock #494

Closed jxc136 closed 1 year ago

jxc136 commented 1 year ago

[X] Card created
[X] Tests written: targeting player, targeting creature

radar commented 1 year ago

Thanks! Another target you might like to include in the tests would be a planeswalker. A Shock to a walker will take off two loyalty counters.

jxc136 commented 1 year ago

Hey @radar - this one actually require some changes to how Planeswalkers work! They didn't have a take_damage method so one had to be added that would call change_loyalty according to value of that damage.

radar commented 1 year ago

Aha! I couldn’t remember if I implemented that or not. Turns out not. So thanks for handling it!