Cards like Barrin currently use the effect system, but they should use the choices system instead. Find resolve_pending_effect and replace them with choices instead. Remove resolve_pending_effect entirely. Effects therefore should act immediately.
When Barrin, Tolarian Archmage enters the battlefield, return up to one other target creature or planeswalker to its owner’s hand.
This is clearly a skippable choice that a play should make (as it says "up to")
I think conflating effects (something happened, so now do this...) with a system that is (something happened, player has to make a choice, then (maybe) do this...) is confusing.
Cards like Barrin currently use the effect system, but they should use the choices system instead. Find
resolve_pending_effectand replace them with choices instead. Removeresolve_pending_effectentirely. Effects therefore should act immediately.This is clearly a skippable choice that a play should make (as it says "up to")
I think conflating effects (something happened, so now do this...) with a system that is (something happened, player has to make a choice, then (maybe) do this...) is confusing.