search

radare / spp

simple preprocessor
MIT License
60 stars 11 forks source link

Rm globals #16

Closed Svenito closed 7 years ago

Svenito commented 7 years ago

Still need to remove

static char *lbuf = NULL;
static int lbuf_s = 1024;
static int lbuf_n;

But made a start and would like some feedback if this is the correct approach for this.

radare commented 7 years ago

For conventions i would pass the state struct reference as first argument

On 20 Apr 2017, at 17:37, Sven Steinbauer notifications@github.com wrote:

Still need to remove

static char *lbuf = NULL; static int lbuf_s = 1024; static int lbuf_n; But made a start and would like some feedback if this is the correct approach for this.

You can view, comment on, or merge this pull request online at:

https://github.com/radare/spp/pull/16

Commit Summary

Remove 'printed' global Remove incmd var Remove bad return value Use already available tokens instead of globals Move parse state to proc File Changes

M main.c (2) M p/cpp.h (24) M p/pod.h (4) M p/spp.h (58) M spp.c (88) M spp.h (12) Patch Links:

https://github.com/radare/spp/pull/16.patch https://github.com/radare/spp/pull/16.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Svenito commented 7 years ago

All globals now removed