raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
57 stars 14 forks source link

Issue with RatingBuster and RCLootCouncil Classic #48

Closed boktai1000 closed 3 years ago

boktai1000 commented 3 years ago

Link to AddOn: https://www.curseforge.com/wow/addons/rclootcouncil-classic

Issue: RatingBuster seems to have some issues when used in conjunction with the RCLC Classic Addon. I've encountered Lua Errors when using the two together, and will include one below.

Additionally, I've seen people mention on the RCLC Discord / Advise to not use the two AddOns together. I'll include links/screenshots for that as well in-case it may help.

(Requires access to RCLC Discord - but see screenshots for snippets of conversations - https://discord.gg/WfYhCx9 ) https://discord.com/channels/427445230870986752/538502872682201108/860329778631933962 https://discord.com/channels/427445230870986752/538502872682201108/859471052849676308 https://discord.com/channels/427445230870986752/538502872682201108/867431894206382111

image

image

image

https://www.curseforge.com/wow/addons/rclootcouncil-classic/issues/149

Here is a link to the Lua error in question:

ratingbuster lua rclc.txt

Thanks for looking into this :)

boktai1000 commented 3 years ago

4x ...ns\RatingBuster\libs\TipHooker-1.0\TipHooker-1.0-67029.lua:270: attempt to index field 'TipHooker' (a nil value) [string "@RatingBuster\libs\TipHooker-1.0\TipHooker-1.0-67029.lua"]:270: in function <...ns\RatingBuster\libs\TipHooker-1.0\TipHooker-1.0.lua:261> string "=[C]": in function CreateFrame' [string "@RCLootCouncil_Classic\RCLootCouncil\core.lua"]:2707: in functionCreateGameTooltip' [string "@RCLootCouncil_Classic\RCLootCouncil\Modules\votingFrame.lua"]:788: in function GetFrame' [string "@RCLootCouncil_Classic\RCLootCouncil\Modules\votingFrame.lua"]:73: in functionOnEnable' [string "@RCLootCouncil_Classic\Core\Hooks.lua"]:55: in function <RCLootCouncil_Classic\Core\Hooks.lua:53>

[string "@AngryAssignments\libs\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <...\AngryAssignments\libs\AceAddon-3.0\AceAddon-3.0.lua:65> [string "@AngryAssignments\libs\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function <...\AngryAssignments\libs\AceAddon-3.0\AceAddon-3.0.lua:520>

[string "@RCLootCouncil_Classic\RCLootCouncil\core.lua"]:2453: in function CallModule' [string "@RCLootCouncil_Classic\RCLootCouncil\core.lua"]:668: in functionorigHandler' [string "@RCLootCouncil_Classic\Core\Comms.lua"]:68: in function <RCLootCouncil_Classic\Core\Comms.lua:66> [string "@RCLootCouncil_Classic\Core\Comms.lua"]:91: in function `?' [string "@AngryAssignments\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:119: in function <...nts\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>

[string "@AngryAssignments\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...nts\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@AngryAssignments\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire' [string "@AngryAssignments\libs\AceComm-3.0\AceComm-3.0-12.lua"]:264: in function <...ns\AngryAssignments\libs\AceComm-3.0\AceComm-3.0.lua:246>

Locals: frameType = "GameTooltip" name = "votingframe_ShoppingTooltip1" parent = votingframeItemTooltip { BottomLeftCorner = { } OnBackdropLoaded = defined @SharedXML\Backdrop.lua:239 backdropBorderColor =

{ } GetBackdropColor = defined @SharedXML\Backdrop.lua:477 TopLeftCorner = { } RightEdge = { } ApplyBackdrop = defined @SharedXML\Backdrop.lua:381 SetBackdrop = defined @SharedXML\Backdrop.lua:416 ClearBackdrop = defined @SharedXML\Backdrop.lua:369 TopOverlay = { } GetBackdropBorderColor = defined @SharedXML\Backdrop.lua:496 GetBackdrop = defined @SharedXML\Backdrop.lua:434 SetBorderBlendMode = defined @SharedXML\Backdrop.lua:353 shoppingTooltips =
{ } SetupTextureCoordinates = defined @SharedXML\Backdrop.lua:301 OnBackdropSizeChanged = defined @SharedXML\Backdrop.lua:269 HasBackdropInfo = defined @SharedXML\Backdrop.lua:365 0 = GetEdgeSize = defined @SharedXML\Backdrop.lua:275 updateTooltip = 0.200000 TopRightCorner = { } TopEdge = { } backdropColor =
{ } Center = { } BottomOverlay = { } backdropInfo =
{ } BottomEdge = { } SetBackdropBorderColor = defined @SharedXML\Backdrop.lua:509 needsReset = true SetupPieceVisuals = defined @SharedXML\Backdrop.lua:333 SetBackdropColor = defined @SharedXML\Backdrop.lua:486 LeftEdge = { } BottomRightCorner = { } } inheritFrame = "ShoppingTooltipTemplate" (for generator) = defined =[C]:-1 (for state) =
{ item =
{ } } (for control) = "item" tipType = "item" (for generator) = defined =[C]:-1 (for state) =
{ 1 = "GameTooltip" 2 = "ItemRefTooltip" 3 = "ShoppingTooltip" 4 = "ComparisonTooltip" 5 = "EQCompareTooltip" 6 = "tekKompareTooltip" 7 = "IRR" 8 = "LinkWrangler" 9 = "LinksTooltip" 10 = "AtlasLootTooltip" 11 = "ItemMagicTooltip" 12 = "SniffTooltip" 13 = "LH_" 14 = "MirrorTooltip" 15 = "TooltipExchangeTooltipShow" 16 = "AtlasQuestTooltip" } (for control) = 3 = 3 v = "ShoppingTooltip" tooltip = votingframe_ShoppingTooltip1 { 0 = BottomLeftCorner = { } BottomOverlay = { } Center = { } OnBackdropLoaded = defined @SharedXML\Backdrop.lua:239 BottomEdge = { } backdropInfo =
{ } GetBackdropColor = defined @SharedXML\Backdrop.lua:477 SetupTextureCoordinates = defined @SharedXML\Backdrop.lua:301 OnBackdropSizeChanged = defined @SharedXML\Backdrop.lua:269 HasBackdropInfo = defined @SharedXML\Backdrop.lua:365 SetBackdropBorderColor = defined @SharedXML\Backdrop.lua:509 RightEdge = { } TopLeftCorner = { } BottomRightCorner = { } GetEdgeSize = defined @SharedXML\Backdrop.lua:275 updateTooltip = 0.200000 TopRightCorner = { } TopEdge = { } ApplyBackdrop = defined @SharedXML\Backdrop.lua:381 SetBackdrop = defined @SharedXML\Backdrop.lua:416 ClearBackdrop = defined @SharedXML\Backdrop.lua:369 TopOverlay = { } GetBackdropBorderColor = defined @SharedXML\Backdrop.lua:496 GetBackdrop = defined @SharedXML\Backdrop.lua:434 needsReset = true SetupPieceVisuals = defined @SharedXML\Backdrop.lua:333 SetBackdropColor = defined @SharedXML\Backdrop.lua:486 LeftEdge = { } SetBorderBlendMode = defined @SharedXML\Backdrop.lua:353 } (for generator) = defined =[C]

raethkcj commented 3 years ago

Thanks, seems like the issue was just some unnecessary global accesses instead of local. I only did a quick test with /rc test 5 but it looked good to me.