search

rafgraph / react-router-hash-link

Hash link scroll functionality for React Router
https://react-router-hash-link.rafgraph.dev
MIT License
732 stars 62 forks source link

Add type definitions? #14

Closed EliRobinson closed 6 years ago

EliRobinson commented 6 years ago

Hello, Just a quick question about whether you plan to create typescript/flow type definitions for this package.

Thanks for doing this! Helped a ton.

rafgraph commented 6 years ago

No. But feel free to add them to the respective centralized type definition repo for everyone to use!

EliRobinson commented 6 years ago

Will look into that, thanks

zoompie commented 6 years ago

Hi,

I made a PR to DefinitelyTyped to support Typescript, it got approved yesterday.

https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-router-hash-link

You can add them using npm install --dev @types/react-router-hash-link