rafgraph / react-router-hash-link

Hash link scroll functionality for React Router
https://react-router-hash-link.rafgraph.dev
MIT License
732 stars 62 forks source link

change host address (doesn't work on Windows) #77

Closed kokushkin closed 3 years ago

kokushkin commented 3 years ago

npm run dev doesn't work for me (Windows). 127.0.0.1 looks good. also https://en.wikipedia.org/wiki/0.0.0.0 says "0.0.0.0 is a non-routable meta-address used to designate an invalid, unknown or non-applicable target"

rafgraph commented 3 years ago

See webpack dev server docs https://webpack.js.org/configuration/dev-server/#devserverhost

Not sure why it’s not working on windows. When you change it to a specific IP address (as you have done) it will only serve from that IP address, which is a good work around, but shouldn’t be checked in as it is specific to your network setup.

kokushkin commented 3 years ago

See webpack dev server docs https://webpack.js.org/configuration/dev-server/#devserverhost

Not sure why it’s not working on windows. When you change it to a specific IP address (as you have done) it will only serve from that IP address, which is a good work around, but shouldn’t be checked in as it is specific to your network setup.

They are similar to me.. as I could figure out 127.0.0.1 points out at the same machine while 0.0.0.0 at all network or even serves like a "wrong reserved address". I don't remember specifics, might be wrong :roll_eyes: All I can say for sure, it doesn't work for me)