search

rambunction4330 / librmb

A library designed to ease the pain of FRC robot programming. TLDR; Make motor spin good better
https://rambunction4330.github.io/librmb/
MIT License
1 stars 1 forks source link

Add current limits and ramp rates for Sparkmaxes #31

Closed theVerySharpFlat closed 1 year ago

theVerySharpFlat commented 1 year ago

I also added ramp rates. Can you make sure that I put the configuration values in the correct struct?

gcjurgiel commented 1 year ago

Looks good! I’d give current a default of maybe 40A since that will keep the motor from ever getting warm, and I might put the open loop ramps in the motorConfig struct since it doesn’t effect closed loop pid behavior. But since we are again modifying the constructor this might change