Closed theVerySharpFlat closed 11 months ago
In the AngularAsLinearVelocity/PositionController, when I implement the setPIDConstant function, it doesn't recognize PIDConfig on its own but needs to reset in the implementation. Rather than having: void setPIDConstant(config) {} I wrote it as: void setPIDConstants(AngularVelocityController::PIDConfig config) {}
I'm not sure if this is an issue or not but this didn't come up in the LinearAsAngularVelocity/PositionControllers
Currently we set PID constants on motor controllers using class-specific structs in their constructors such as
https://github.com/rambunction4330/librmb/blob/fa88a2271c1595d770312ef8158c5ee46ec20940/src/rmb/motorcontrol/falcon/FalconPositionController.h#L30-L38
However, we want to have a unified method of setting PID constants across all motorcontrollers.
To do this, you will have to
You should start this work on a git branch called "feature/PIDFunction" and create a pull request on GitHub when you finish.