ramn / metrics_cloudwatch

CloudWatch emitter for the metrics crate
7 stars 9 forks source link

feat: Report how many counts the metric instance received #10

Closed Marwes closed 4 years ago

Marwes commented 4 years ago

Instead of reporting the max and min of each increment_counter request. Gives more information in the common case of sending counts of 1 at the cost of not reporting the min and max value passed to increment_counter.

In a perfectly orthogonal world a counter would not let us observe by how much it was incremented with each time, but as long as we do we should choose whatever is most useful. This makes increments observable across metric collectors but not within them which should be more useful since gauges can cover much of ground when wanting to observe min and max in the same metric collector.

ramn commented 4 years ago

The Sum is already contained in the StatisticsSet

Marwes commented 4 years ago

Do a release!

ramn commented 4 years ago

Working on it

ramn commented 4 years ago

Had to write a changelog!

ramn commented 4 years ago

Publish complete