ramn / metrics_cloudwatch

CloudWatch emitter for the metrics crate
7 stars 9 forks source link

Let's update to use the latest metrics crate and cloudwatch sdk #45

Open jregistr opened 7 months ago

jregistr commented 7 months ago

This crate is using the pre-release version of the sdk. Current version is 1... https://github.com/awslabs/aws-sdk-rust

Additionally, would be nice to support the latest metrics version.

jregistr commented 7 months ago

I'm looking into this one since I'd be using that change. Looks a bit involved 😅

The Recorder trait has changed since the last version. It now expects a returned type implementing CounterFn, GaugeFn, and HistogramFn.

impl Recorder for RecorderHandle {
    fn describe_counter(&self, key: KeyName, unit: Option<Unit>, description: SharedString) {
        todo!()
    }

    fn describe_gauge(&self, key: KeyName, unit: Option<Unit>, description: SharedString) {
        todo!()
    }

    fn describe_histogram(&self, key: KeyName, unit: Option<Unit>, description: SharedString) {
        todo!()
    }

    fn register_counter(&self, key: &Key, metadata: &Metadata<'_>) -> metrics::Counter {
        todo!()
    }

    fn register_gauge(&self, key: &Key, metadata: &Metadata<'_>) -> metrics::Gauge {
        todo!()
    }

    fn register_histogram(&self, key: &Key, metadata: &Metadata<'_>) -> metrics::Histogram {
        todo!()
    }
}