search

rampa069 / ZX-ESPectrum

A ZX spectrum 48K/128K emulator running on ESP32 with bitluni ESP32 VGA Board (also in TTG VGA32)
153 stars 46 forks source link

Fixing keyboard for some games, also fixing the README.md #8

Closed dcrespo3d closed 4 years ago

dcrespo3d commented 4 years ago

Hello,

I have made a small change in the code which handles keyboard input which I thing makes it more general. It handles all cases your code did, and a few more.

Most games read keyboard state using individual ports (high port FE/FD/FB/F7/EF/DF/BF/7F). But other games different approaches. For example, Manic Miner from Matthew Smith reads port 7E (which happens to be a combination of FE and 7F) for using any key in the bottom row for jumping. This code handles ALL cases.

Also, I have noticed that newer versions of Bitluni's ESP32Lib VGA driver won't work with this project (0.3.3 won't compile), so I think you should state it in your README.md. I have changed it for you.

Regards and congratulations on your excellent work. This is the project I would have done myself if you hadn't done it before, and saved me all the work :)

dcrespo3d commented 4 years ago

This is the original pull request I intended for the master branch, I will use a different branch for the wiimote stuff.

jorgefuertes commented 4 years ago

Oh, ok, haven't seen this before the wiimote merge. Great work David, ty.

dcrespo3d commented 4 years ago

:-)