search

rancher / tf-rancher-up

MIT License
14 stars 5 forks source link

Feature/GitHub actions #131

Closed glovecchi0 closed 3 months ago

glovecchi0 commented 3 months ago

Converted CI pipeline from Drone to GitHub Action

glovecchi0 commented 3 months ago

It doesn't appear the GH action was run and don't see it listed at https://github.com/rancher/tf-rancher-up/actions . Perhaps GH actions need to be enabled for the repository.

I would also revert the GKE version change from this PR.

Reverted GKE version change.

dnoland1 commented 3 months ago

@leodotcloud Can you check if GitHub actions have been enabled for this repository?

leodotcloud commented 3 months ago

I have merged this PR. I don't think the pipelines get triggered from forks. Need to create a branch directly on the repo and create a PR.

leodotcloud commented 3 months ago

I have created a PR here: https://github.com/rancher/tf-rancher-up/pull/133. Please feel free to contribute directly to that branch.