randlab / geone

DeeSse interface, utilities and examples
Other
37 stars 11 forks source link

Merge geo-cross-validation to geone #4

Closed pjuda closed 4 years ago

pjuda commented 4 years ago

Key features:

No external dependencies were added.

The next step would be:

EDIT: the tasks above are finished

pjuda commented 4 years ago

The tasks above are finished. I think that geone-cv is ready to be merged.

Further steps, before submitting the cross-validation paper:

pjuda commented 4 years ago

I'm closing the pull request for the moment as I'm not sure if I could improve further the example use case. Now the user needs to build the DeesseEstimator from scratch (by copying their DeeSseInput...). Maybe it's better to reuse the DeesseInput to construct the estimator. In this way, the cross-validation can be more easily applied to existing models without the need to copy existing code.