search

rapidjs / rapid.js

An ORM-like Interface and a Router For Your API Requests
https://rapidjs.drewjbartlett.com
711 stars 45 forks source link

Add typescript definitions #24

Closed BrainMaestro closed 6 years ago

BrainMaestro commented 6 years ago

For people that prefer to work in typescript, would you be interested in adding type definitions? I can work on the PR if you are.

drewjbartlett commented 6 years ago

@BrainMaestro I actually am not crazy familiar with TS. I would LOVE to learn it more. I host a meetup in my town and we are going over TS in the next talk https://www.meetup.com/BendJS/events/245313573/. Hoping to learn some then!

My only concern with making a PR at this point in time is that I want to make sure I can still easily update and maintain the code which I'm not sure I'll be able without knowing TS very much.

BrainMaestro commented 6 years ago

Oh, I'm not suggesting that you convert the existing code to typescript. I'm suggesting adding a single definition file that contains the type information for the entire project. Similar to this

drewjbartlett commented 6 years ago

Ah okay. I misunderstood. Well then, yeah, if it's not going to effect anyone who doesn't use TS, I am all in! Feel free to submit a PR

RichiCoder1 commented 6 years ago

I had the exact same thought when I first saw this library :). The big question will be how best to flow types 🤔