search

rapidjs / rapid.js

An ORM-like Interface and a Router For Your API Requests
https://rapidjs.drewjbartlett.com
711 stars 45 forks source link

add .editorconfig and edit .gitignore #44

Closed yihou closed 6 years ago

yihou commented 6 years ago

add .editorconfig to make sure the coding style is consistent throughout. update .gitignore to avoid commit IDE config files

drewjbartlett commented 6 years ago

@yihou thanks for this! Could you write a description of what this is doing so I can know what to look for? Also - did you get the latest changes from this branch that were made last week?

mgred commented 6 years ago

@yihou I beg your pardon for my later review, i did not notice this was still pending. I just submitted.

yihou commented 6 years ago

@drewjbartlett My bad, just removed the prefix paths

yihou commented 6 years ago

@mgred no worries, I got busy the these few weeks too, btw, I did change it to @babel/preset-env

mgred commented 6 years ago

@yihou I just noticed that there are still some js files in your branch.

It's important to note that the v2-refactor branch misses the 'Interceptor feature' which will most likely change, since the new version will work with adaptors to allow axios to be replaced by another http client. So I think we don't need this feature anyways. This would also apply to the changes in default.ts. Also, the feature itself has a lack not to support error interceptors as explained by @M3psipax above. So I guess we will rework this so we can use the proposed workaround.

Sorry, I saw this way too late.

drewjbartlett commented 6 years ago

@yihou @mgred have been on a trip but will look at this asap. Thanks a TON!

yihou commented 6 years ago

@mgred sorry, just saw your message, might not know what to do with the core.js and test/interceptors.test.js yet.

mgred commented 6 years ago

@yihou I think you can just delete them.

drewjbartlett commented 6 years ago

@mgred @yihou thanks for the hard work on this. I have been buried with work but I am excited to hop back on this with you guys!

To the point of the interceptors. I may be worthwhile to write a new feature that still gives some support for this. I'm not sure what that looks like but I do know it was a largely requested feature

drewjbartlett commented 6 years ago

@yihou you are the man! Thanks for this work. Sorry it took me so long. v2 is gonna be amazing!