Closed mgred closed 6 years ago
Executed jest
on the branch mgred:rapid.js-41
:
@mgred thanks a ton for this! Have you pushed this into the branch? I started a refactor last night in another branch that will keep all tests green as I work. Here's my tentative plan for the moment:
// @ts-check
in the heading of the file to loosely ts check the filesLet's hang tight for a week or so and then we can actually get this bad boy rollin'! I seriously appreciate all your help!
@drewjbartlett sounds good so far, this is all in the branch you just merged so the tests run as well on v2-refactor
Just to get things straight we will keep fixing test step-by-step with the refactoring plan, and not doing at once?!
I also noticed that the build output is still not satisfying, means is not working. I could also work on this, I think this is just related to some settings in the tsconfig.json
. Or is there any other task which you think I can face next?
I'm pretty sure we're getting v2 out soon.
This issue is for fixing all tests
npm run unit