rapidjs / rapid.js

An ORM-like Interface and a Router For Your API Requests
https://rapidjs.drewjbartlett.com
711 stars 45 forks source link

V2 attempt two #47

Closed drewjbartlett closed 6 years ago

drewjbartlett commented 6 years ago

@mgred I don't want to scare you off with this but I finally went ahead and rewrote rapid to be almost what I wanted it to be. Everything is extracted into short and concise methods. Almost everything is under test. But I ran my tests continually while I refactored to ensure the current implementation did not break. I used // @ts-check on these files to get them prepped for typescript.

I am nearly finished getting this to a good place and then if you're not scared away we can work together to add in TS while keeping the files .js if possible. I need to rewrite the debugger and some more tests and then we will be golden to get v2 out the door! If you still want to help, while you implement TS into this, I can update the documentation :D.

Let me know your thoughts! I also don't expect that you have to give this PR a thorough review since I have all my tests passing and made a butt ton of changes.

Version 2 Checklist

mgred commented 6 years ago

@drewjbartlett Wow that's massive work, I will review and merge asap. I will also update with master, since the branch seems to be a bit behind.

mgred commented 6 years ago

@drewjbartlett Alright this thing is merged. :boom:

If you still want to help, while you implement TS into this, I can update the documentation

Sure, that sounds good. Let's do it!!

I would like to define more detailed tasks and put them into issues to have a better overview.

drewjbartlett commented 6 years ago

@mgred I wasn't quite ready to make a merge which was totally my bad for specifying :D. I can revert

mgred commented 6 years ago

@drewjbartlett, easy let me know