Closed drewjbartlett closed 6 years ago
@mgred sorry about the miscommunication there! Let's keep this branch open for the moment. I want to get you a better checklist than the one above as well. I will make an effort to do this weekend! We can either work off this branch or likely off develop
which I just made :D
@drewjbartlett No worries! Nice, thanks for your effort.
@mgred I don't want to scare you off with this but I finally went ahead and rewrote rapid to be almost what I wanted it to be. Everything is extracted into short and concise methods. Almost everything is under test. But I ran my tests continually while I refactored to ensure the current implementation did not break. I used
// @ts-check
on these files to get them prepped for typescript.I am nearly finished getting this to a good place and then if you're not scared away we can work together to add in TS while keeping the files
.js
if possible. I need to rewrite the debugger and some more tests and then we will be golden to get v2 out the door! If you still want to help, while you implement TS into this, I can update the documentation :D.Let me know your thoughts! I also don't expect that you have to give this PR a thorough review since I have all my tests passing and made a butt ton of changes.
Version 2 Checklist
.js
filesapi
renamed tohttp
qs
forqs-stringify
since we only use that method https://www.npmjs.com/package/qs-stringifyprepublish
hook and replace with: Useprepare
for build steps andprepublishOnly
for upload-only.rapid.use(customRouter)