search

rapidpro / rapidpro-docker

14 stars 34 forks source link

Changes made recently in praekeltfoundation/rapidpro-docker #18

Closed smn closed 7 years ago

smn commented 7 years ago

These are the changes we've made recently, all our rapidpro deploys go off of our praekeltfoundation docker hub account as we've been needing to trial features being developed for RapidPro before they were merged in.

The only change left in our fork is some stuff relating to builds happening on a Concourse CI installation for local deploys.

tobiasmcnulty commented 7 years ago

@smn Thanks for all the changes! This looks great. Only thing I really have an opinion about is S3, the other stuff I'm happy to test over time.

smn commented 7 years ago

@erikh360 could you have a look at the changes @tobiasmcnulty is recommending wrt S3? You added those changes for some of our projects.

smn commented 7 years ago

@erikh360 bump :point_up:

smn commented 7 years ago

How close are we to being able to get this merged?

tobiasmcnulty commented 7 years ago

I'm good for you to go ahead and merge, if I run into any issues I'll submit PRs as I go. Thanks for doing this!

erikh360 commented 7 years ago

Thanks @tobiasmcnulty, I added the comment so this should be good to merge pending tests @smn.