search

razorpay / go-financial

A go port of numpy-financial functions and more.
MIT License
310 stars 22 forks source link

Rate function added #17

Closed thsubaku9 closed 3 years ago

thsubaku9 commented 3 years ago

This PR adds the Rate calculation function to go-financial (using Newton Rapson for the root calculation)

thsubaku9 commented 3 years ago

@gyanesh-m sorry to bother you but I think something is wrong with the CI. Do let me know when things are fixed so that I can continue with the PR

gyanesh-m commented 3 years ago

@thsubaku9 The pipeline is fine. There are errors in golangci-lint check. Find them locally using make lint-check. Make sure you have golangci-lint installed. If not, use make install-lint to install it.

thsubaku9 commented 3 years ago

Let me know if any more changes are required @gyanesh-m

gyanesh-m commented 3 years ago

@thsubaku9 will review the changes over weekend.

thsubaku9 commented 3 years ago

lets gooooooo @gyanesh-m

thsubaku9 commented 3 years ago

Lets go ? @gyanesh-m

thsubaku9 commented 3 years ago

Any updates here ? @krantideep95 @gyanesh-m @captn3m0

gyanesh-m commented 3 years ago

Hey @thsubaku9, I will review this over the coming weekend.

gyanesh-m commented 3 years ago

@thsubaku9 Thank you for adding this to go-financial ! 💯 🎉