search

rbn42 / panon

An Audio Visualizer Widget in KDE Plasma
GNU General Public License v3.0
191 stars 31 forks source link

Panon should tell PulseAudio its name #23

Closed flying-sheep closed 4 years ago

flying-sheep commented 4 years ago

I filed bastibe/SoundCard#81. Once they fixed it, we can adapt the client’s start method to set the name:

https://github.com/rbn42/panon/blob/653a7ee73be21cb7ba2f51d24b4ece78e19aea02/panon/backend/source.py#L105-L132

rbn42 commented 4 years ago

In case you find it too difficult to support it in SoundCard, you can create a patch for pulseaudio.py in this repo.

self.context = _pa.pa_context_new(self.mainloop_api, b"panon")

Just a suggestion.

rbn42 commented 4 years ago

Thank you for your time and contribution. I just released a new version.

flying-sheep commented 4 years ago

And the AUR package is updated! With the new soundcard installed, I now see:

image

rbn42 commented 4 years ago

And the AUR package is updated

Awesome! Would you mind to add cmake to makedepends to solve #22?

rbn42 commented 4 years ago

By which I mean

- makedepends=('kpackage')
+ makedepends=('kpackage' 'cmake')
flying-sheep commented 4 years ago

ah sure, done. I also think you don’t need to have a PKGBUILD here, having one copy in the AUR should be sufficient