search

rbn42 / panon

An Audio Visualizer Widget in KDE Plasma
GNU General Public License v3.0
191 stars 31 forks source link

[BUG] AUR Build Fail with missing ECM #33

Closed yuannan closed 3 years ago

yuannan commented 3 years ago

Desktop (please complete the following information):

Describe the bug AUR build fails with:

CMake Error at CMakeLists.txt:7 (find_package):
  Could not find a package configuration file provided by "ECM" with any of
  the following names:

    ECMConfig.cmake
    ecm-config.cmake

  Add the installation prefix of "ECM" to CMAKE_PREFIX_PATH or set "ECM_DIR"
  to a directory containing one of the above files.  If "ECM" provides a
  separate development package or SDK, be sure it has been installed.

Fix: extra-cmake-modules needed as depenency

rbn42 commented 3 years ago

First, cmake is only required to build and install translations. And extra-cmake-modules is required by https://github.com/rbn42/panon/blob/stable/CMakeLists.txt, which is used by AUR build. Originally, I copied this cmakelist from Plasmoid's development tutorial. But I think we can discard this file, and use https://github.com/rbn42/panon/blob/stable/translations/CMakeLists.txt directly to build and install translations. 

cd panon/translations/
mkdir build
cd build 
cmake ..
make install DESTDIR=~/.local/share/locale/ or /usr/share/locale/ 
or ~/.local/share/plasma/plasmoids/panon/contents/locale/ 
or /usr/share/plasma/plasmoids/panon/contents/locale/

So that this extra-cmake-modules is not required.

@flying-sheep I see you updated v0.4.2 recently on AUR, Thanks. What do you think about this issue? Because the current AUR build relies on that cmakelist to install panon, adding extra-cmake-modules as depenency would be the easier solution.

flying-sheep commented 3 years ago

If you change the way this is supposed to be built, I’ll change the PKGBUILD accordingly.

Most people should have extra-cmake-modules as it’s required to build most things KDE, but if panon is the only thing people ever build, not requiring it is a teensy tiny advantage.

rbn42 commented 3 years ago

If you change the way this is supposed to be built, I’ll change the PKGBUILD accordingly.

OK, I have changed it in README.ORG.

flying-sheep commented 3 years ago

Okay, I’ve subscribed to realeases, so hopefully I’ll see when you release. If not, please mark it as outdated in the AUR