rclement / datasette-dashboards

Datasette plugin providing data dashboards from metadata
https://datasette-dashboards-demo.vercel.app
Apache License 2.0
137 stars 7 forks source link

Fix markdown lists rendering #147

Closed rclement closed 1 year ago

rclement commented 1 year ago

Fixes #139

codecov[bot] commented 1 year ago

Codecov Report

Merging #147 (17a40ae) into master (8526dcc) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          377       377           
  Branches        72        72           
=========================================
  Hits           377       377           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rclement commented 1 year ago

@havef could you review the feature-branch deployment and check the fix is correctly applied on your side please? https://fix-markdown-lists-dd-demo.vercel.app/-/dashboards/job-offers-stats

(I also took the liberty of making sure ordered lists are displaying numbers instead of bullets, which is a current bug within the Datasette CSS)

HaveF commented 1 year ago

@rclement Thanks for your work! It works great. Regarding the issue with the sql display, I believe it would be better to wait for the upstream plugin to be fixed.

rclement commented 1 year ago

Thanks for your feedback @HaveF.

I did take a closer look to datasette-render-markdown and I found out that enabling Python-Markdown extensions is supported! By enabling the extra extension group, fenced code (block code snippets) and tables are now properly supported!

HaveF commented 1 year ago

@rclement Wow! It looks very nice now 😍