rclement / datasette-dashboards

Datasette plugin providing data dashboards from metadata
https://datasette-dashboards-demo.vercel.app
Apache License 2.0
137 stars 7 forks source link

Update README with dashboard layout examples #149

Closed rclement closed 1 year ago

rclement commented 1 year ago

Related to discussion #141

codecov[bot] commented 1 year ago

Codecov Report

Merging #149 (bdd0ebe) into master (54a41a2) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          377       377           
  Branches        72        72           
=========================================
  Hits           377       377           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rclement commented 1 year ago

@HaveF I updated the README with more layout instructions and examples, especially the neat feature of CSS grids to specify empty spots within the grid using the . (full stop) character. Could you review everything is clearer now?

HaveF commented 1 year ago

Do we need to emphasize this: If a component is not in the layout configuration, it is placed at the end of the entire layout.

rclement commented 1 year ago

Do we need to emphasize this: If a component is not in the layout configuration, it is placed at the end of the entire layout.

Mmmh good point. An out-of-grid chart being placed in the lower right corner seems like a bug (I've seen it happen) but it should be more of a layout validation before-hand (there is none for now) issue preventing this behavior.

I've already added a warning concerning the equal number of columns, maybe adding another one that "all charts must be placed on the custom layout"?

HaveF commented 1 year ago

LGTM