search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

0.56.x Discussion #14

Closed grabbou closed 6 years ago

grabbou commented 6 years ago

Please report any major issues and commits to cherry-pick in this thread for discussion.

iRoachie commented 6 years ago

Could we get this in? https://github.com/facebook/react-native/commit/746945824a426a6f16555df0f12f92d836d5cc18

grabbou commented 6 years ago

It's not yet cut, so everything in master lands into it.

Titozzz commented 6 years ago

Does this means we will get babel 7 in 0.56 ♥️ 🎉 ?

grabbou commented 6 years ago

Not really. I am probably going to cut 0.56 before Babel 7 change as it still needs some fixes to get master green. We will do it for the 0.57 I guess.

On Mon, 23 Apr 2018 at 12:18 Thibault Malbranche notifications@github.com wrote:

Does this means we will get babel 7 in 0.56 ♥️ 🎉 ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/14#issuecomment-383526464, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxvE8kaHFQtjVkQZ1TiE0RE58GHV8ks5trappgaJpZM4TFPgN .

Titozzz commented 6 years ago

Oh well, I guess I'll wait one more then. Can't wait for this ! Babel 7 is finally coming. 🎉

maraujop commented 6 years ago

This was requested in 0.55.x discussion https://github.com/react-native-community/react-native-releases/issues/11#issuecomment-380121877 and I'm requesting it again for 0.56.x a fix for TextInputs in iOS https://github.com/facebook/react-native/pull/18278

MarkOSullivan94 commented 6 years ago

Can we please get this sorted ASAP? https://github.com/facebook/react-native/issues/18095

Don't want to see a lot of RN projects unable to update their Android apps on the store in Nov 2018. Or new projects not being able to publish their apps in August 2018.

grabbou commented 6 years ago

This will get addressed at some point since Facebook and other companies are also using React Native. Don't be worried. Unfortunately, this thread is not the right place to discuss it.

But you have my word it's being worked on.

On Mon, 14 May 2018 at 11:42 MarkOSullivan94 notifications@github.com wrote:

Can we please get this sorted ASAP? facebook/react-native#18095 https://github.com/facebook/react-native/issues/18095

Don't want to see a lot of RN projects unable to update their Android apps on the store in Nov 2018. Or new projects not being able to publish their apps in August 2018.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/14#issuecomment-388758194, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxqU3RbBCsnhFobV4URyKnLFQ2Qagks5tyVF1gaJpZM4TFPgN .

MarkOSullivan94 commented 6 years ago

Also curious if there's any plans to include Gradle 3.x support in this release?

https://github.com/facebook/react-native/pull/17747

Titozzz commented 6 years ago

I guess it will be nice for react-native to update @MarkOSullivan94 but I'm already using both sdk 26 and gradle 3.0 without issue on production, please tell me if I can help.

MarkOSullivan94 commented 6 years ago

I don't need help upgrading to either, I'm using target version 27 and the latest version of gradle which comes with AS 3.2 canary 14.

Posting these issues just because there might be a lot of people who are on old versions which will need to be upgraded (target api a higher priority just because it'll stop RN from releasing updates / being publish in the not to distant future)

vrgimael commented 6 years ago

I looked up in many places and couldn't really find any info... what's the status on the 0.56 release?

Thanks

turnrye commented 6 years ago

Work is taking place to get master back to a stable state. There are multiple efforts presently underway for this. I suspect that late next week, RC activities will pick up.

grabbou commented 6 years ago

Yup, currently Hector from Facebook (@hramos) is leading internal efforts on making the CI green again. We will use this thread to notify every one of the progress (if any).

I also hope that CI gets green soon and next RC gets released, but given that we are slowly approaching an end of this month, I'll be looking at the beginning of June as a potential time for next RC.

rawrmaan commented 6 years ago

Would love to know more about the RN Fabric efforts going into this release. I can't seem to find any information about Fabric, its advantages, roadmap, etc.

sibelius commented 6 years ago

Gradle 3 support would make build faster

danielkcz commented 6 years ago

Also with Gradle 3 it would be easier to use new RN Firebase modules ... https://rnfirebase.io/docs/v4.2.x/installation/migration-guide

Honestly, I tried to go through that migration guide and had some weird issues with so I hope it comes to RN by default.

noahtallen commented 6 years ago

Agreed. We switched to gradle 3+ and build tools 27+ without much issue ourselves, but would be nice to have it up-to-date by default.

jsdario commented 6 years ago

Is there a PR ready for that? I think gradle 3 is a nice-to-have, but probably should not be a priority for a release candidate, but rather something that can land before v0.57.

MarkOSullivan94 commented 6 years ago

@jsdario I already posted a link to the PR for it: https://github.com/facebook/react-native/pull/17747

MarkOSullivan94 commented 6 years ago

Could someone help me with this issue? I've made changes to the React Native Share API a week ago and I'm wanting to test my changes to ensure that Android can now share images now: https://github.com/facebook/react-native/issues/19358

Would love to get the fix done ASAP and get it in for 0.56.x

grabbou commented 6 years ago

Please keep this thread related to commits that are already merged to React Native master. Meanwhile, if you need any additional help in the main React Native repo, feel free to ping me or Hector.

kelset commented 6 years ago

A couple of commits I'd like to see in this release:

rawrmaan commented 6 years ago

Got a little bit of clarity on Fabric: https://twitter.com/dan_abramov/status/1003395928831791104

musicode commented 6 years ago

When to release this version?

kelset commented 6 years ago

@musicode

Please keep this thread related to commits that are already merged to React Native master. Meanwhile, if you need any additional help in the main React Native repo, feel free to ping me or Hector.

musicode commented 6 years ago

@kelset Is master stable?

kelset commented 6 years ago

Quick update, @grabbou said that more or less today (https://twitter.com/grabbou/status/1005783171298885632) the new release will be cut.

To answer @musicode, yes technically master is stable.

anandprabhu commented 6 years ago

Thanks for the update @kelset i hope this also includes the fix for the sourcemap issue in the metro bundler by @rafeca is also included

hramos commented 6 years ago

The 0.56 Release Candidate is now available

The new release has been cut. You may now use v0.56.0-rc.

Requesting backports

May I kindly request that any future conversation on this thread be limited to backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.56 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

MarkOSullivan94 commented 6 years ago

Out of interest was Gradle 3.x support removed?

MarkOSullivan94 commented 6 years ago

Can we please have anything which didn't make the 0.56.0 release be added for 0.57.x or one of the 0.56.x releases (some clarification on the aims of what will be done and when would be perfect)

kelset commented 6 years ago

@MarkOSullivan94 as @hramos wrote, please

May I kindly request that any future conversation on this thread be limited to backport (cherry-pick) requests from commits that are already on master.

Or I will lock this thread.

Out of interest was Gradle 3.x support removed?

You can check the Changelog here and no, it wasn't removed. And it's not in the roadmap.

Can we please have anything which didn't make the 0.56.0 release be added for 0.57.x or one of the 0.56.x releases (some clarification on the aims of what will be done and when would be perfect)

When 0.56.0 will be released, we'll create two new issues in this repo related to 0.57.x. To know which commits will land where, you can follow this issue and #15 (and the ones for 0.57.x once they are created).

hramos commented 6 years ago

I'd like to nominate the following commits for cherry-picking onto 0.56:

Update: these have been cherry-picked onto 0.56-stable.

hramos commented 6 years ago

Gradle 3.x support and requests related to Android for a future release are best suited for the Android roadmap umbrella issue in the main React Native repo: https://github.com/facebook/react-native/issues/19297

hramos commented 6 years ago

Here's a couple of issues that have been raised about 0.56.0-rc so far:

hramos commented 6 years ago

Cherry-picking https://github.com/facebook/react-native/commit/065c5b6590de18281a8c592a04240751c655c03c as requested by @dulmandakh in https://github.com/facebook/react-native/issues/19297#issuecomment-397060485

dulmandakh commented 6 years ago

From August 2018, Play Store will require to target SDK 26 for new applications and November for app updates.

So, I think that we must to target SDK 26 in August release to make sure applications developed with React Native be accepted in Play Store.

My plan was to compile July release with SDK 26 then target SDK 26 in August release (just in time) to make transition to SDK 26 smoother and to see if there are issues to address. Therefore, I would like to ask to land https://github.com/facebook/react-native/commit/065c5b6590de18281a8c592a04240751c655c03c in July release, so we have time to test, fix bugs and maybe land SDK 26 features like custom fonts, better emoji support etc.

grabbou commented 6 years ago

This commit should be part of next release, which will be RC next month and become stable as of the beginning of August. Given that people usually do not test RCs, I think it makes sense to cherry-pick this commit, esp. that the branch has been like a few days ago.

Let's keep it on the list until the cherry-picks grow to a bigger number so it's worth making next release.

kelset commented 6 years ago

@grabbou I think @hramos already cherry picked it and released under 0.56.rc.1 - and because of that I think we'll have to merge&cherry pick at least another PR (details in the comments here https://github.com/facebook/react-native/pull/19662) (and in the core Slack channel, I wrote a bit more there)

Ashoat commented 6 years ago

I'd like to request a cherry-pick for https://github.com/facebook/react-native/commit/1ffb2b63be4c4af331fece0b4286e5c92b1e575d

It fixes a pretty bad iOS TextInput bug where fake backspace events get triggered.

hramos commented 6 years ago

@Ashoat done.

mgenov commented 6 years ago

Tried to switch to RN 0.56.0-rc.2 but getting "Unknown named module: 'NativeModules':

screen shot 2018-06-16 at 18 22 51

package.json versions 

    "react": "16.3.2",
    "react-dom": "16.3.2",
    "react-native": "^0.56.0-rc.2",
     ....
    "babel-preset-react-native": "5.0.2",

Build Tools & SDK

app/build.gradle

compileSdkVersion 27
buildToolsVersion '27.0.3'

build.gradle

classpath 'com.android.tools.build:gradle:3.1.2'
classpath 'com.google.gms:google-services:3.2.1'

logcat logs

06-16 18:45:35.101  7550  7754 D RNFirebaseAuth: RNFirebaseAuth:initialized
06-16 18:45:35.106  7550  7754 E BluetoothAdapter: Bluetooth binder is null
06-16 18:45:35.107  7550  7754 D ReactNative: Initializing React Xplat Bridge.
06-16 18:45:35.120  7550  7759 I OMXClient: Using client-side OMX mux.
06-16 18:45:35.131  7550  7754 D ReactNative: Initializing React Xplat Bridge before initializeBridge
06-16 18:45:35.153  7550  7754 D ReactNative: Initializing React Xplat Bridge after initializeBridge
06-16 18:45:35.154  7550  7754 D ReactNative: CatalystInstanceImpl.runJSBundle()
06-16 18:45:35.154  7550  7758 D ReactNative: ReactInstanceManager.setupReactContext()
06-16 18:45:35.154  7550  7758 D ReactNative: CatalystInstanceImpl.initialize()
06-16 18:45:35.157  7550  7550 W unknown:ReactNative: Packager connection already open, nooping.
06-16 18:45:35.157  7550  7758 D ReactNative: ReactInstanceManager.attachRootViewToInstance()
06-16 18:45:35.231  7550  7581 D ReactNative: CatalystInstanceImpl.destroy() end
06-16 18:45:35.689  7550  7757 W ResourceType: No package identifier when getting value for resource number 0x00000000
06-16 18:45:35.721  7550  7757 E ReactNativeJS: Unknown named module: 'NativeModules'
06-16 18:45:35.746  7550  7757 E ReactNativeJS: Module AppRegistry is not a registered callable module (calling runApplication)
06-16 18:45:35.799  7550  7577 D EGL_emulation: eglMakeCurrent: 0xaa9a5440: ver 3 0 (tinfo 0xaa9bdb10)
06-16 18:45:35.843  7550  7560 I art     : Background sticky concurrent mark sweep GC freed 53161(2MB) AllocSpace objects, 0(0B) LOS objects, 20% free, 11MB/14MB, paused 1.751ms total 111.559ms
06-16 18:45:59.181  1251  1295 D hwcomposer: hw_composer sent 3212 syncs in 60s
06-16 18:46:59.186  1251  1295 D hwcomposer: hw_composer sent 3237 syncs in 60s
06-16 18:47:59.180  1251  1295 D hwcomposer: hw_composer sent 3218 syncs in 60s
06-16 18:48:59.192  1251  1295 D hwcomposer: hw_composer sent 3244 syncs in 60s

Any idea what could cause the issue ?

mgenov commented 6 years ago

The problem was related with the remote-redux-devtools. It works as expected when the usage of remote-redux-devtools was removed.

xzilja commented 6 years ago

I believe this is another issue related to 0.56.0rc https://github.com/facebook/react-native/issues/19763

Played around with this in vanila project as well

paolospag commented 6 years ago

I'm really curious to try RN 0.56.0-rc.2 and I updated my RN 0.55.4 project via react-native-git-upgrade (previously I upgraded babel preset to 5.0.1 version).

The upgrade fails with some warnings and one error about parenthesis ("unexpected token...").

Is there a way to correctly upgrade to the newest version via react-native-git-upgrade?

xzilja commented 6 years ago

@paolospag Try to update babel preset to 5.0.2

eshikerya commented 6 years ago

After upgrading via react-native-git-upgrade the app working in simulator, but crashing on init stage in production build on device. Removed all plugins, nothing works. Any clue?

paolospag commented 6 years ago

@IljaDaderko thank you for your answer!

I tried to update babel preset to 5.0.2, but I encountered the same error:

git-upgrade info Install the new version
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.3 (node_modules\sane\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN jest-react-native@18.0.0 requires a peer of react-native@>=0.38.0 but none was installed.
npm WARN react-native-firebase@3.3.1 requires a peer of react-native@>= 0.48.0 but none was installed.
npm WARN react-native-material-menu@0.3.1 requires a peer of react-native@>= 0.54.0 but none was installed.
npm WARN react-native-splash-screen@3.0.6 requires a peer of react-native@>=0.47.0 but none was installed.
git-upgrade info Generate new version template
git-upgrade ERR! An error occurred during upgrade:
git-upgrade ERR! C:\Users\USER_NAME\Desktop\DEV\APP\node_modules\babel-preset-react-native\transforms\transform-symbol-member.js:44
            ),
            ^

SyntaxError: Unexpected token )
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Module._extensions..js (module.js:579:10)
    at Object.require.extensions.(anonymous function) [as .js] (C:\Users\USER_NAME\AppData\Roaming\npm\node_modules\react-native-git-upgrade\node_modules\babel-register\lib\node.js:152:7)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
git-upgrade ERR! Restore initial sources
M       package.json
Note: checking out 'project-snapshot'.

Any idea about this? I noticed that the new CHANGELOG says "Node 8 is now the minimum required version [...]", but in my dev environment I'm still using Node.js 6.11.4... Could this be?

kelset commented 6 years ago

So, quick couple of new cherry picks requests :

EXTRA: I think we should try to get this merged and cherry picked: https://github.com/facebook/react-native/pull/19645