0.59.x Discussion

[grabbou]

Conversation on this thread are limited to 0.59 releases, major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[grabbou]

@Kennytian, make your start script: react-native start instead of node ./node_modules/react-native/local-cli/cli.js.

@blainekasten, you should call react-native start or yarn react-native start instead of using node to point to a manual file. If you need to do that, make sure to point to ./node_modules/@react-native-community/cli/build/index.js. I don't recommend doing that.

This was an unintended breaking change and we are shipping a 0.59.0-rc.1 right now with a fix.

[xzilja]

Hey guys,

Upgraded my project from 0.58.4 to 0.59.0-rc.0. (Applied all steps as per diff https://github.com/pvinis/rn-diff-purge/compare/version/0.58.4...version/0.59.0-rc.0)

One issue pops up when building iOS

project/Pods/Folly/folly/portability/Config.h:20:10: 'folly/folly-config.h' file not found

This is after cleaning build folder, reseting packager cache etc... also, project includes react native through Cocoapods (not sure if relevant) i.e.

  pod 'yoga', :path => '../../node_modules/react-native/ReactCommon/yoga'
  pod 'DoubleConversion', :podspec => '../../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../../node_modules/react-native/third-party-podspecs/Folly.podspec'
  pod 'React', :path => '../../node_modules/react-native', :subspecs => [
    'Core',
    'CxxBridge',
    'DevSupport',
    'RCTAnimation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTText',
    'RCTWebSocket'
  ]

EDIT: running third party install script manually didn't help either node_modules/react-native/scripts/ios-install-third-party.sh

[Salakar]

@IljaDaderko same here;

With sometimes there being no error output at all;

[danilobuerger]

When will rc1 be available via npm?

[grabbou]

We are having some issues with the CI so can’t guarantee any dates. We are working on it. On Thu, 14 Feb 2019 at 17:05, Danilo Bürger notifications@github.com wrote:

When will rc1 be available via npm?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-463684229, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxvH9Am88AutRSAUsO5s3jSpOCdpIks5vNYkwgaJpZM4aGpI1 .

[hramos]

Heads up, there's a bug in Hooks that would be nice to get fixed before 0.59 stable is cut. It looks like a fix for this might land next week if all goes well, so we should be able to get it into the 0.59-RC before it's too late.

[yurykorzun]

It looks like React.podspec is broken. Core subspec is missing Folly headers in search paths.

[ltcaosj]

react-native link command does not work.

[dulmandakh]

created PR to fix link command https://github.com/react-native-community/react-native-cli/pull/170

[ltcaosj]

unlink command is also not working.

The assets link also does not work. "rnpm": { "assets": [ "./src/assets/fonts/" ] }

[grabbou]

CLI issues fixed in 1.2.3 release. Please reinstall your node_modules to get a fix automatically.

[dulmandakh]

cherry pick:

• fix Android crash issue https://github.com/facebook/react-native/commit/19492b730b6779486f83d5ddbaeeb870cb3d5e9c. please include this in the next RC.

[mattias-altsater]

CLI issues fixed in 1.2.3 release. Please reinstall your node_modules to get a fix automatically.

Even after yarn cache clean I still get v1.2.2 when reinstalling. Do I need to specify the version somewhere? I don't see v1.2.3 on NPM.

[dulmandakh]

cherry pick:

• bump Android Plugin to 3.3.1, to silence warning in Android Studio - https://github.com/facebook/react-native/commit/da5b5d2fa134aa09dda4a620be9fa4d3d419201f

[guhungry]

CLI issues fixed in 1.2.3 release. Please reinstall your node_modules to get a fix automatically.

Even after yarn cache clean I still get v1.2.2 when reinstalling. Do I need to specify the version somewhere? I don't see v1.2.3 on NPM.

delete yarn.lock then yarn install

Hey @danilobuerger, @huczk and @raajnadar don't get me wrong. Even if new version cli was published to npm. yarn cache clean won't be enough to get new version.

[ChrisEdson]

1.2.3 is not yet on NPM

[grabbou]

@swensonmattias my bad, try it out now. CLI (version 1.2.3) should be out now.

[ltcaosj]

With the latest master, the react-native link command is working fine now but the react-native unlink command still does not work.

[yilmar0309]

problem to react-native start, i add typescript here https://facebook.github.io/react-native/blog/2018/05/07/using-typescript-with-react-native

[grabbou]

React Native 0.59.0-rc.1 is out, contains few Android fixes (as requested by @dulmandakh earlier) and CocoaPods fix.

[yilmar0309]

React Native 0.59.0-rc.1 is out, contains few Android fixes (as requested by @dulmandakh earlier) and CocoaPods fix.

@grabbou update react-native-cli? I still have the same error. (Unknown)

[xzilja]

I can still see same error as in https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-463628317 within rc1. Was cocoapods fix for that or something else? Perhaps @Salakar @yurykorzun or @Bardiamist can confirm?

[narobertson42]

Please can this be considered for cherry-picking https://github.com/facebook/react-native/commit/dd209bb7891ed5f05b96a9922c7b0e39bf3ac9e9 there have been iOS web socket issues in all versions since 0.57

[yurykorzun]

I can still see same error as in #79 (comment) within rc1. Was cocoapods fix for that or something else? Perhaps @Salakar @yurykorzun or @Bardiamist can confirm?

I cannot build 0.59 rc1 using a podspec, the same Folly compiler issue remains. There were no changes committed to React.podspec. I added "$(PODS_ROOT)/Folly/folly"- recursive to header search paths and then it produced another compiler error in fishook. It says cstdlib is missing.

I am not sure what needs to be changed in podspec to match settings in React.xcodeproj.

[hramos]

There's an issue in 0.59 we should fix before hitting stable: https://github.com/facebook/react-native/issues/23235

[fkgozali]

There's an issue in 0.59 we should fix before hitting stable: facebook/react-native#23235

Let's pick this commit: https://github.com/facebook/react-native/commit/a9dd828c68338dbf0e55ffa1838bf8ff574f317d

[gaodeng]

Would be nice to include https://github.com/facebook/react-native/commit/f15145639dab1e8d7a1c79a127b7d45c91d025a8

[spyr0s]

I have this error using 0.59.0-rc.1

FAILURE: Build failed with an exception.

* Where:
Script '.../node_modules\react-native\react.gradle' line: 95

* What went wrong:
A problem occurred configuring project ':app'.
> Could not get unknown property 'mergeResourcesProvider' for object of type com.android.build.gradle.internal.api.ApplicationVariantImpl.

[Federkun]

@spyr0s , refer to https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-463448276

[Salakar]

@yurykorzun @IljaDaderko I have a fix for the folly issue. I will send up a PR shortly if you could apply it locally let me know.

Edit: PR up https://github.com/facebook/react-native/pull/23488 - if you apply locally; make sure to clean your ios/build folder, remove the generated pods workspace & pods dir and finally pod install - should build fine after all that

[xzilja]

Applied @Salakar 's PR and folly issue is resolved 👍

[grabbou]

Going to wait for @Salakar PR to land and will release 0.59.0-rc.2 with fixes mentioned in this thread since the last release.

[Sharlaan]

Not sure where to report htis issue, but trying RN 0.59-rc.1 (and React 16.8.2) on Win10 led me to a path resolution problem :

I never got this issue with previous versions.

[Salakar]

@grabbou PR has landed 🎉

[grabbou]

Cherry-picked requested commits and pushed the release for tests. Will try to publish it soon.

Note: I am marking comments that talk about resolved issues as "resolved" to keep visibility on the issues that we haven't fixed yet or known problems (e.g. upgrading Android SDK). It's just an experiment.

[grabbou]

0.59.0-rc.1 is on CircleCI, should be live soon.

Cherry-picked 3 commits, including CocoaPods fix. See them here

CLI work is happening in a different repository, reinstalling node_modules should do the trick.

[thymikee]

@Sharlaan can you translate this error to English? I'm not sure what's wrong there.

Ok, good ol Google Translate gives me this: "'D\Mes' is not recognized as an internal or external command, an executable program or a batch file"

Looks like something has troubles with spaces on Windows.

[Sharlaan]

Sorry i thought it would be self-explanatory.

Basically it says that it fails to execute what it think to be a cli command, because of the space in the path D://My projects/..

[thymikee]

@Sharlaan Thanks! Which version of Node are you running?

[Sharlaan]

last, v11.10

[thymikee]

Did it work for you earlier? This code hasn't really changed since extraction

[Sharlaan]

after i searched for the previous version of RN i were using i found out it were 0.58.4 but most importantly, the repo were manually settled... ... unlike here i tested using directly expo init then yarn upgrade'd RN React and expo.

[thymikee]

I don't have a Windows machine, and paths with spaces work on UNIX. I'd appreciate your help on that. The relevant code is here: https://github.com/react-native-community/react-native-cli/blob/760d384ae199ccd6552805459c195ed5aa3969fc/packages/cli/src/cliEntry.js#L142-L146

It may be an Expo issue as you say, but it's possible that we can make it easier for them on our side.

[Sharlaan]

ok i made another fresh test which worked flawlessly :

... but after upgrading, red screen (LAN mode) :

Installing RN@next (v0.59-rc.2) ...

then expo start crashes with the issue mentioned in my previous post.

error Command failed: D:\Mes Projets\expo-and-typescript\mobile3\expo-ts\node_modules\@react-native-community\cli\setup_env.bat
'D:\Mes ' is not recognized as internal command.

... so i think the issue definitely does not come from expo, since it worked with the RN@exotic version.

[Sharlaan]

I made a few research about childProcess.execFile and found this in Node documentation : https://nodejs.org/api/child_process.html#child_process_spawning_bat_and_cmd_files_on_windows (especially last example)

Any space in the argument passed to childProcess.execFileSync tells it there is a command executable. So maybe the solution would be to enclose the whole path string in quotes (using JSON.stringify) ?

[thymikee]

@Sharlaan feel free to try it! :)

[grabbou]

0.59.0-rc.2 is out on npm now.

[kelset]

@thymikee @Sharlaan can you please move your conversation to an issue in the main repo? So that we can avoid polluting this issue

[ltcaosj]

- Cannot run DEBUG on a real iOS device - Cannot even run RN app on a real Android device Reproduce: Just init a new RN app ---> got those issues

[kelset]

@ltcaosj please open a dedicated issue on the main repo following the template.