search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

0.59.x Discussion #79

Closed grabbou closed 5 years ago

grabbou commented 5 years ago

Conversation on this thread are limited to 0.59 releases, major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

ltcaosj commented 5 years ago

@kelset , I thought the issue is related to 0.59.x release, so I put it here. Let me put it in the main repo then.

akshetpandey commented 5 years ago

@grabbou : https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-460410565 isn't resolved and I feel like its still a blocker for 0.59 release. Its being discussed here: https://github.com/react-native-community/jsc-android-buildscripts/issues/82

danilobuerger commented 5 years ago

Please cherry pick: Map TextInput textContentType strings to Objective-C constants https://github.com/facebook/react-native/commit/a89fe4165c2a331a9d88636d89a5a48151ab8660

dulmandakh commented 5 years ago

Cherry picks:

ziqiDev commented 5 years ago

when will update the version of gradle to 5.0?

dulmandakh commented 5 years ago

@ziqiDev it's landed in master, and will be a part of 0.60 release https://github.com/facebook/react-native/commit/b4017a9923b09fed4b693a8e4cfadd30ce34c88d

ltcaosj commented 5 years ago

I just installed the latest release of 0.59.x : The Live Reload does not work - I need to reinstall the app every time making a code change.

t3chnoboy commented 5 years ago

@ltcaosj I have the same issue. The development server is not exposed to the local network. As a workaround you can start the dev server like this: react-native start --host 0.0.0.0

ltcaosj commented 5 years ago

thanks @t3chnoboy , your workaround solution works ;)

kelset commented 5 years ago

@ltcaosj @t3chnoboy it looks like it's a CLI issue, can you please open one in the dedicated repo so that it can be investigated?

ltcaosj commented 5 years ago

@ltcaosj @t3chnoboy it looks like it's a CLI issue, can you please open one in the dedicated repo so that it can be investigated?

https://github.com/facebook/react-native/issues/23589

sunnylqm commented 5 years ago

Please cherry pick: https://github.com/facebook/react-native/commit/d9489c4e9c646b79025f07635b840e9974be8cd5

dulmandakh commented 5 years ago

Cherry picks:

tomduncalf commented 5 years ago

Hey, wanted to report an issue I've found with 0.59rc2.

Our project can't use the -ObjC linker flag to discover/load all symbols as it causes "duplicate symbol" errors for some of the static libraries we use (ObjC is all-or-nothing flag, so we can't opt these out of it, and the "duplicate symbols" are valid as we depend on the same shared library from multiple other libraries). As RN depends on this behaviour, the alternative is to use -force_load for each library that needs to be loaded in this way and specify the path to the compiled (.a) library.

With 0.58 this compiles fine, but with 0.59rc2 it results in "duplicate symbol" errors for some Yoga references in libReact.a:

screenshot 2019-02-25 at 18 10 14

I've created a repro case: https://github.com/tomduncalf/rn0.59-force-load-bug - in the interest of keeping the project simple, the path to libReact.a needs to be manually changed in "Linker Flags", you can discover it by going to ~/Library/Developer/Xcode/DerivedData and looking for the directory starting forceLoad59rc2-.... then replacing the existing one with this path (feels like there should be a $(..) variable pointing to this location but I've never found it!).

There is also a rn@0.58 branch in that repo to show it compiles OK in the current release version - you may need to "Clean Build Folder" and/or clear the DerivedData folder to see the change when switching branches.

Please let me know if you'd like more help looking into this issue or reproducing it - this would be a blocking issue for our project as we can't compile with -ObjC.

FLGMwt commented 5 years ago

Can we please cherry-pick: https://github.com/facebook/react-native/commit/b9d3743cda95d1f475dbec8f6d72935941519deb ?

Not a regression or security fix, but it addresses a pretty big long-standing gap w/ a11y on Android.

hramos commented 5 years ago

@tomduncalf can you open a new issue in https://github.com/facebook/react-native and try and make it clear it's present in the 0.59 RC? It will be easier to track that way.

tomduncalf commented 5 years ago

@hramos sure, https://github.com/facebook/react-native/issues/23645 raised. Thanks!

ericlewis commented 5 years ago

Can we cherry pick: https://github.com/facebook/react-native/commit/8ce3c1b43edd47191c8e5ee8432c58f6e93dfca7

Solves an issue we have had since 2016: https://github.com/facebook/react-native/issues/5859.

hramos commented 5 years ago

Please cherry pick https://github.com/facebook/react-native/commit/d4ce8463a853a29cc977fcbf390b43940f521bd2. This commit bumps React to v16.8.3 and updates the React Native renderer accordingly.

akshetpandey commented 5 years ago

https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-465368826 is resolved.

grabbou commented 5 years ago

@akshetpandey - do you mean we are good to go? My understanding from https://github.com/react-native-community/jsc-android-buildscripts/issues/82 is that it's not a blocker for 0.59 anymore.

akshetpandey commented 5 years ago

Yes, its not a blocker for 0.59. Looks like 0.59 improves on 0.58 behavior.

grabbou commented 5 years ago

Awesome! Going to "resolve" all the comments then to clean it up! Thank you so much for being active in that topic here and in that issue!

grabbou commented 5 years ago

0.59.0-rc.3 is out

zenz commented 5 years ago

should upgrade the .flowconfig to version 0.93.0 it seems this version(flow-bin@0.93.0) solved the 'flow check dosen't work under windows' issue. https://github.com/facebook/react-native/issues/21311

StasDoskalenko commented 5 years ago

Hey guys! Please add this to 0.59 https://github.com/facebook/react-native/commit/f3e5cce4745c0ad9a5c697be772757a03e15edc5

vdlindenmark commented 5 years ago

I'm getting this error when trying to run my app in release mode (iOS, Xcode, Cocoapods, RC3)

Undefined symbols for architecture arm64:
  "_RCTSetLogFunction", referenced from:
      -[AppName testRendersWelcomeScreen] in AppName
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
hramos commented 5 years ago

@vdlindenmark can you open a new issue in the React Native repository instead? Just make sure to make it clear it affects 0.59.0-rc.3 and to include a link back to this issue so we can keep track of it. I'll hide your comment to make sure we keep this thread to cherry-pick requests.

hramos commented 5 years ago

@StasDoskalenko that is already part of 0.59, and it's one of the tentpole features for this release.

hramos commented 5 years ago

@zenz please stick to cherry-pick requests for commits that are already in React Native master. Please do open a new issue in the React Native repository if you have not yet, and link back to this issue. That way we can keep track of work that might benefit this release. Thanks!

shawnthye commented 5 years ago

Hi, will this https://github.com/facebook/react-native/pull/23430 come into the next patch?

vdlindenmark commented 5 years ago

@vdlindenmark can you open a new issue in the React Native repository instead? Just make sure to make it clear it affects 0.59.0-rc.3 and to include a link back to this issue so we can keep track of it. I'll hide your comment to make sure we keep this thread to cherry-pick requests.

I'm sorry. You could ignore my message. I've didn't configure the cocoapods right, discovered that this morning

grabbou commented 5 years ago

Cherry pick https://github.com/facebook/react-native/commit/e10d984c437187b2cfdb364248c93a261d3f5e46 to upgrade Jest from an alpha release.

satyen-progton commented 5 years ago

Please use android:usesCleartextTraffic="true" in AndroidManifest to allow development server run on android 9.0 devices

hramos commented 5 years ago

@satyen-progton please send a pull request to the core RN repository. We are only handling cherry pick requests in this thread.

kelset commented 5 years ago

@satyen-progton @hramos - actually @Salakar already added this to the docs -> https://facebook.github.io/react-native/docs/integration-with-existing-apps#network-security-config-api-level-28 (select the Android tab and mid way you'll see a dedicated section).

May be worth highlighting in the changelog for 0.59 cc @turnrye

furkancelik commented 5 years ago

ios or android file cannot be recreated. (dont work react-native eject)

I get the following error when I run the react-native eject command when I want to delete and re-create the iOS or Android file.

ekran resmi 2019-03-01 23 18 34
kelset commented 5 years ago

@furkancelik please open a dedicated issue in the correct repo (probably the RNCli one).

OlivierFreyssinet-old commented 5 years ago

Hi! Is this https://github.com/facebook/react-native/commit/58c3a4c078c066038baa9a961afae498557a1e18 going to be in 0.59 ?

sunnylqm commented 5 years ago

Hi can you cherry pick this one https://github.com/facebook/react-native/commit/d2153fc58d825006076a3fce12e0f7eb84479132

tijp commented 5 years ago

Hello! Can https://github.com/facebook/react-native/pull/23446 be cherry picked for 0.59?

ChrisEdson commented 5 years ago

Out of interest, how close are we getting to a stable release of 0.59? It would be good purely because we're sort of in a holding pattern for developing things with hooks.

grabbou commented 5 years ago

We are waiting for the changelog and blog post announcing 0.59 and we will be making it stable. If it's not ready today, then, it's going to be Monday to avoid releasing on Friday.

On Thu, 7 Mar 2019 at 09:19 Chris Edson notifications@github.com wrote:

Out of interest, how close are we getting to a stable release of 0.59? It would be good purely because we're sort of in a holding pattern for developing things with hooks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-470429646, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxqYYv9uviMoj6WDzEJNJ2Sr4gnxPks5vUMuVgaJpZM4aGpI1 .

matei-radu commented 5 years ago

So facebook/react-native#23645 is not a release blocker anymore? Has it been solved in RC 3?

grabbou commented 5 years ago

Didn't know about that one, thanks for cross-posting.

On Thu, 7 Mar 2019 at 10:23 Matei Radu notifications@github.com wrote:

So facebook/react-native#23645 https://github.com/facebook/react-native/issues/23645 is not a release blocker anymore? Has it been solved in RC 3?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-470449319, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxtRJWzEjd6iKyom9kKfVYcioZuumks5vUNqmgaJpZM4aGpI1 .

hramos commented 5 years ago

The release blocker label tracks issues introduced during the RC period, and is meant to help us avoid shipping a regression in a stable release. It is not intended for these issues to prevent new RC patches from being created.

matei-radu commented 5 years ago

@hramos Then I simply misinterpreted its meaning, thanks for clarifying!

grabbou commented 5 years ago

We decided to wait with 0.59 stable release till next week (Monday/Tuesday) till there's more context on the aforementioned regression. We want to be sure whether it's a major that should be fixed before a stable release happen or a minor that we can disclose in the changelog as a "known issue".

cjroth commented 5 years ago

Ahoy!

  1. Excited about 0.59 stable.
  2. Given that it's going to be released Mon/Tue, looks like this memory leak will have to wait until 0.60? :( https://github.com/facebook/react-native/issues/23801

Seems like it should be fairly high priority.

kelset commented 5 years ago

@cjroth given that, as you posted in the issue, this seems to be a long lasting issue with RN (going as far as 0.57 at least) it won’t be considered a blocker for the release on 0.59.0. OFC any help you can provide over there in terms of debugging it and PRs will be super appreciated, and we’ll see how we can prioritize it against the current roadmap & pipeline.

Also, the PR with the fix of the blocker mentioned above is being imported, so hopefully we can still release 0.59.0 next week.