react-native-progress-view / progress-view

ProgressView Component for react-native iOS/macOS/Windows
MIT License
176 stars 49 forks source link

RN 0.72.3 + fabric enabled => RNCProgressViewComponentDescriptors.h file not found ? #131

Closed zabojad closed 1 year ago

zabojad commented 1 year ago

I just freshly installed @react-native-community/progress-view on my RN 0.72.3 project with fabric enabled.

Trying to build the project in XCode now fails with error: node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:6:9 'react/renderer/components/progressview/RNCProgressViewComponentDescriptors.h' file not found

Screenshot 2023-07-18 at 16 56 00

Anyone getting this too?

zabojad commented 1 year ago

If I debug what codegen does with this:

node node_modules/react-native/scripts/generate-codegen-artifacts.js --path ./ --outputPath ./ios-debug

I indeed get slightly different filenames that what is imported in RNCProgressViewComponentView.mm:

Screenshot 2023-07-18 at 17 01 46
zabojad commented 1 year ago

Now if I "fix" those imports with the right pathes given by codegen debug, I get other errors:

/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:114:28: error: unknown type name 'ImageRequest'
  auto getCoordinator = [](ImageRequest const *request) -> ImageResponseObserverCoordinator const * {
                           ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:122:33: error: no member named 'getProgressImageSource' in 'facebook::react::RNCProgressViewState'
  if (!havePreviousData || data.getProgressImageSource() != _oldState->getData().getProgressImageSource()) {
                           ~~~~ ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:122:82: error: no member named 'getProgressImageSource' in 'facebook::react::RNCProgressViewState'
  if (!havePreviousData || data.getProgressImageSource() != _oldState->getData().getProgressImageSource()) {
                                                            ~~~~~~~~~~~~~~~~~~~~ ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:123:58: error: no member named 'getProgressImageRequest' in 'facebook::react::RNCProgressViewState'
    self.progressImageCoordinator = getCoordinator(&data.getProgressImageRequest());
                                                    ~~~~ ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:126:33: error: no member named 'getTrackImageSource' in 'facebook::react::RNCProgressViewState'
  if (!havePreviousData || data.getTrackImageSource() != _oldState->getData().getTrackImageSource()) {
                           ~~~~ ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:126:79: error: no member named 'getTrackImageSource' in 'facebook::react::RNCProgressViewState'
  if (!havePreviousData || data.getTrackImageSource() != _oldState->getData().getTrackImageSource()) {
                                                         ~~~~~~~~~~~~~~~~~~~~ ^
/Users/thomasfetiveau/wksp_myproj/my-proj/node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:127:55: error: no member named 'getTrackImageRequest' in 'facebook::react::RNCProgressViewState'
    self.trackImageCoordinator = getCoordinator(&data.getTrackImageRequest());

😭😭😭

stee1ix commented 1 year ago

I'm facing this issue as well.

nutstick commented 1 year ago

I just found that publish package is missing the common folder (which is where RNCProgressViewComponentView .mm located). I have created https://github.com/react-native-progress-view/progress-view/pull/136 for the fix.