real-ezTheDev / GodotEzDialoguePlugin

MIT License
146 stars 12 forks source link

Removal of recursion in favour of O(n) for loop #18 #21

Closed SeanKR-IRE closed 4 months ago

SeanKR-IRE commented 4 months ago

I removed the recursion function to allow for better readability for anyone to use, Either works fine now, having 1 variable input feels much nicer however

_nexted_state_reference didn't need inject modifier, my first implementation it was used to differentiate between if was text injection or eval expression.

One small QOL if possbible, i tried finding a variable that had the node name "start" "test_variable_injection_in_text" etc but couldn't find it. having any of the printerr() messages with the prefix of the dialogue node name would be ideal for debugging. example for "_test_conditional_missing_variable" being "Error['_test_conditional_missing_variable']: Can't find expression ' test_variable ' in the stateReference: { }" or something to that effect. just having the node name inside would be perfect