search

real-ezTheDev / GodotEzDialoguePlugin

MIT License
109 stars 10 forks source link

When changing name/removing already "connected" nodes, error messaging fills the log #3

Closed real-ezTheDev closed 5 months ago

real-ezTheDev commented 7 months ago

This has no actual impact on the functionality, but the extra error lines printed on log every time I updated an already connected dialogue node is annoying.

adrientremblay commented 6 months ago

I get this too. It triggeres without me necessarily doing something. Possible has something to do with the current state of my dialogue.json.

update: so the error appears when I load my dialogue.json and I click one of the nodes. Then it begins producing an error like every second

image

adrientremblay commented 6 months ago

So the error states that 'from' is an invalid index on the connection dictionary. The .get_connection_list() documentation states that the returned dict will be in the form of { from_port: 0, from: "GraphNode name 0", to_port: 1, to: "GraphNode name 1" }.

but (see screenshot) it seems the dict instead of having to and from keys has from_node and to_node? Was there a change in the Godot engine that changed the key names recently? Seems the documentation is out of date. perhaps this is grounds for opening an issue on the Godot GH page

image

adrientremblay commented 6 months ago

I created an issue on the Godot repo. Apparently the issue has already been fixed and will be out in an upcoming 4.2 release. The documentation will be updated to match the current dict format.

https://github.com/godotengine/godot/issues/86780

real-ezTheDev commented 5 months ago

hey @adrientremblay thanks for working on this. It may take me a second to figure out your merge request haha.. I'll get back to this issue and your merge request soon.

real-ezTheDev commented 5 months ago

it does appear, the issue with log error when changing connected node name is fixed. However, the "deletion" still triggers it. I believe it is because there are other parts of the code that still uses "to" as well instead of "to_node" will correct.

real-ezTheDev commented 5 months ago

Found that manually "disconnecting" connection when also "queue_free" on the graph nodes would result in "node not found" error. Making changes to skip the manual "disconnection" of nodes when "deleting" a node.

real-ezTheDev commented 5 months ago

verified issues are fixed in dev branch. Will go out to main branch in the next major update.