realthunder / FreeCAD

Link branch FreeCAD
Other
779 stars 45 forks source link

[Problem] Sketcher symmetry ignores external geometry. #1006

Closed mbelt closed 1 week ago

mbelt commented 4 months ago

Is there an existing issue for this?

Version

0.21 (Development)

Full version info

[code]
OS: Arch Linux
Word size of FreeCAD: 64-bit
Version: 0.21.0.38935 (Git)
Build type: Release
Branch: makepkg
Hash: a0d6ece6c0e7b64dca6b2066a7d57b982a9f2a17
Python 3.11.6, Qt 5.15.12, Coin 4.0.2, Vtk 9.3.0, OCC 7.7.2
Locale: English/United States (en_US)
Installed mods: 
  * freecad.gears 1.2.0
[/code]

Subproject(s) affected?

Sketcher

Problem description

The sketcher buttons that copy geometry (symmetry, clone, array) do not copy external geometry.

Anything else?

No response

Code of Conduct

realthunder commented 1 week ago

The above commit enables copying of external geometry. There is some limitation at the moment. It is due to the fact that there is no constraints on the external geometries or between them. Say you copy a set of connected external edges, there is no coincident constraint between them, so you'll have to connect them manually. There is also complication if you copy geometry that constrains to an external geometry. Because it is not obvious visually which external geometry are constrained against. See below for example. The geometry is connected to the arrow pointed external edge, but not the other one. If you copy the edge together with the wrong external edge, the copies won't be connected. This problem exists for normal geometry copying as well, but it will be more obvious when external geometry is involved, since there is no constraints between them in the first place.

image