search

realthunder / FreeCAD

Link branch FreeCAD
Other
787 stars 45 forks source link

Redirection of spinlokd post #672

Open wsteffe opened 1 year ago

wsteffe commented 1 year ago

Hi RT, have you seen this problem affecting LinkDaily ? https://forum.freecadweb.org/viewtopic.php?f=44&p=651405#p651405

realthunder commented 1 year ago

I trace back the problem seems to stem from the second Pad feature. You can check the geometry of that feature. Make sure to enable BOP check. It'll report some problem.

image

It is known that BOP check is sometimes over sensitive to minor problems, but it is a clue. If I extended the sketch a bit, the problem goes away. Make sure you change the sketch constraint so that the top edges remains at the exact same place to avoid topo naming complain in later feature. There will sill be complain in some, but we are only concern about feature up to feature Bottom Attachment Screw Holes.

image

After the sketch modification, I can now add a hole to Sketch007 without problem

image

BTW. I've added a new auto fix function. And I've tested it that it can correct the problem without the sketch adjustment. I'll make a release soon.

KangZhaoKui commented 1 year ago

Hi,Lei I think the key point is Sketch001 height form 73mm change to 89mm; I don't know why, maybe it can give you some inspiration;

And i think Sketch005 have some issues and it doesn't meet the specification;

https://user-images.githubusercontent.com/45224709/210930390-455ee00a-5133-4e55-bcc8-34ed5d57d34e.mp4

https://user-images.githubusercontent.com/45224709/210930409-e2e96b1b-9452-41e0-a706-454ac9191cbb.mp4

spinlokd commented 1 year ago

I think the issue is not about the specific constraint in Sketch001, but more about forcing a recompute by making a change. I have started by making the constraint change first and then try to add the additional hole. That didn't work. However when I went back and modified the Sketch001 again by deleting the constraint, it made the new hole appear. Additionally, I tried to change Ring Reinforcement Cutout pocket to do "Up To Face" instead of "Through all". That also causes an issue, even if I cancel the change. When I executed Recompute action (at 1:07 mark), additional features became broken

I have attached a screen recording. Unfortunately it doesn't capture the right-click context menu.

https://user-images.githubusercontent.com/6809104/211133841-38fcefcf-4aa9-4ad1-8ebf-f30dd9576872.mp4

wsteffe commented 1 year ago

Hi spinlokd, you are right. And I think that it can not be an OCC problem.

The problem is better seen on a simpler test case in which fillets are removed: MountSimple.zip

The problem is reproduced with following steps: 1) Add a third circle in Sketch007: The holes are not made and geometry is corrupted. 2) Set "Mark To Recompute" on Sketch001 3) Apply a "Recompute Object" to Mount Body: The 3 holes are done and geometry is OK.

realthunder commented 1 year ago

Hmm... that's indeed the case. But there is even simpler way to fix it. Just recompute Support Ring immediately when open the file. And then adding third circle will be fine. It's not the first time I see this ghostly problem. There must be some problem buries some where and needs further investigation.