reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
448 stars 85 forks source link

SWS/S&M Extension beta #236

Closed Jeff0S closed 10 years ago

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 19, 2011 13:28:11

This is a "fake" issue we create so that people can report issues/regression about the upcoming beta (Jan 2011, build #1), if any. Links with changelog and other details are coming soon..

Please, first, take a look to the SWS Extension Beta Policy ( https://code.google.com/p/sws-extension/wiki/Betas ).

Also, please answer the following questions. It will help and save us some (precious) time. Thanks!

What steps will reproduce the problem? What is the expected output? What do you see instead? What version of SWS extension are you using? (Extensions -> About SWS...) What Reaper version #? 32 or 64 bit? What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?)

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=236

Jeff0S commented 10 years ago

From swstim on January 19, 2011 05:23:44

Labels: -Type-Defect Type-Beta

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 19, 2011 07:21:38

Full changelog and details here: http://forum.cockos.com/showthread.php?p=665610#post665610

Jeff0S commented 10 years ago

From swstim on January 22, 2011 12:59:58

Summary: SWS/S&M Extension beta (Jan 2011, build #3)
Status: Started
Labels: -Priority-Medium Priority-High

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 22, 2011 15:50:16

"SWS/FNG MIDI: select muted MIDI notes" and "SWS/FNG MIDI: select notes nearest edit cusor" randomly corrupt MIDI note lengths and/or their positions

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 22, 2011 16:00:59

Jeff0S commented 10 years ago

From swstim on January 22, 2011 16:55:59

Mmm, I don't know much about the MIDI data format stuff, so I'll have to leave the fix for the random corruption to you guys.

Cc: fingersmcgarnickle

Jeff0S commented 10 years ago

From fingersmcgarnickle on January 23, 2011 00:32:20

Jeffos I can reproduce the muted events one. I will have a look later on tonight.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 23, 2011 02:33:44

hi fingers! here's attached an example project: for both actions, open the ME for the MIDI item (last take), run the action and look at what happen to the events that where close to the edit cursor. For undos: no bug in fact, it's just that there's no undo points for these actions (the ones I tested, at least).

Attachment: FNG_bugs.RPP

Jeff0S commented 10 years ago

From fingersmcgarnickle on January 23, 2011 05:53:15

Undos are not working for some MIDI actions. I keep flip-flopping between using Undo_BeginBlock with Undo_EndBlock for item changes and Undo_OnStateChange for item changes. I get better results with Undo_OnStateChange so I will stick with it now. Unless you guys can advise otherwise.

The muted midi bug was introduced recently after some v4 fixes. It will be fixed in my next submit. Thanks for testing and the bug report Jeffos!

Jeff0S commented 10 years ago

From fingersmcgarnickle on January 23, 2011 07:15:20

Hey Jeffos, some of the notes in the midi takes in FNG_bugs.rpp have zero length! Which makes weird things happen when modifying the item state. I tried modifying the notes slightly by changing the note lengths to one tick, but weird things still happen. The only way I can get something nice to happen is to remove zero length notes. What is the purpose of them anyway?

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 23, 2011 09:04:24

No idea why there are notes with have zero length in there! It's one of my test project, it contains "normal" MIDI takes that were recorded with the virtual MIDI keyboard. Removing them seems consistent to me as well..

Jeff0S commented 10 years ago

From swstim on January 23, 2011 11:01:13

Released build #4 to fix these minor issues:

Groove Tool fixes: +Fixed pass through to main window +Fixed muted midi events bug introduced in v2.0.0 #3 +Modified Undo handling for items

Fixed auto color needing to be forced in some situations Fixed some screenset loading issues

Summary: SWS/S&M Extension beta (Jan 2011, build #4)

Jeff0S commented 10 years ago

From fingersmcgarnickle on January 26, 2011 05:14:48

FNG_bugs.RPP now works fine with my latest commit. It removes the zero length notes.

Jeff0S commented 10 years ago

From swstim on January 26, 2011 18:19:27

Uploaded 2.0.0.5:

FNG Groove Tool Updates: +Fixed applying strength to velocity groove quantize +Added separate velocity strength control to Groove Tool (set to zero to disable either) +Fixed refresh of groove list in Groove Tool when changing folders +Remove zero length notes when modifying MIDI take state (bad things happen otherwise) +Code cleanup and performance improvements for MIDI take state reading and writing +Added "FNG: Groove Tool..." to the Extensions menu +Removed menu bar and moved applicable items to the context menu +Removed "passthrough" action/keyboard section workaround

S&M updates: +Resources view:

Fixed bug that "silently" deleted items in SWS lists while renaming (Thanks, Bevosss) 4 new actions: "SWS: Set all takes to next/prev mono/stereo channel mode"

Summary: SWS/S&M Extension beta (Jan 2011, build #5)

Jeff0S commented 10 years ago

From swstim on January 30, 2011 21:07:42

It's been very quiet, I suppose that's a good thing! Changelog below, for the record:

!v2.0.0 #7 (January 29, 2011) NEW: Preliminary version of "Autorender." Thanks, Shane! For more information, run Autorender: show instructions from the File->Autorender menu (or actions).

Added actions: +SWS/S&M: Show take pitch envelope - v4 only (visible but no-op in v3) +SWS/S&M: Hide take pitch envelope - v4 only (visible but no-op in v3) +SWS/S&M: Copy selected track gouping +SWS/S&M: Cut selected tracks grouping +SWS/S&M: Paste grouping to selected tracks

Notes/help view fixes: +Pass keystrokes to the main window when locked (i.e. lock button) +Properly init S&M project notes with REAPER ones when possible

!v2.0.0 #6 (January 27, 2011) Fixed corruption of last item in auto color list Fixed keyboard focus issues Improved groove tool keyboard handling (#5b) Improved "SWS: Set all takes to next/prev mono/stereo channel mode" actions

Summary: SWS/S&M Extension beta (Jan 2011, build #7)

Jeff0S commented 10 years ago

From swstim on February 01, 2011 19:58:15

v2.0.0 #8 Autorender updates: +No need to enter data into the project notes field, now use "Autorender: Edit project metadata" +Unicode character support (Windows only? Testing needed)

Support for v4 empty take lanes (more to come): Example: with items starting with a v4 empty take, some actions were broken or had no effect.. +"Fixed" all S&M actions relate to takes +"Fixed" take envelope processing in Padre's Envelope LFO Generator and Envelope Processor

Added pitch take envelope support for Padre's Envelope LFO Generator and Envelope Processor (v4 only)

Summary: SWS/S&M Extension beta (Jan 2011, build #8)

Jeff0S commented 10 years ago

From swstim on February 01, 2011 20:09:03

... and the rest of the changelog that I missed:

Added actions: +SWS/S&M: Copy active take +SWS/S&M: Cut active take +SWS/S&M: Paste take +SWS/S&M: Paste take (after active take)

House cleaning (more to come): +Main "Extensions" menu: added Padre's Envelope LFO Generator and Envelope Processor +Main "Extensions" menu: removed Xenakios' "Misc/Experimental" sub-menu (actions remain available in the action list) +Media item context menu: removed Xenakios' "Item/Take selection" and "Item/Take manipulation" sub-menus (actions remain available in the action list and in the main "Extensions" menu) +TCP context menu: removed Xenakios' "Track/Mixer/Envelopes" sub-menu (actions remain available in the action list and in the main "Extensions" menu) +Tagged action "Xenakios/SWS: Project media..." as deprecated Issue 50 : SWS: Create regions from sel item(s) named with take Issue 126 : Warn about recording same inputs on multiple tracks: http://www.standingwaterstudios.com/shup/RecInputCheck.png Also added actions "SWS: Enable/Disable checking for duplicate inputs when recording." Issue 244 : Added "SWS: Set selected take(s) to custom color X" actions Issue 246 : Added toolbar-status only action "SWS: Are any tracks soloed? [no-op, for toolbar]" Fixed using Windows generated reaconsole_customcommands.txt files on OSX.

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on February 03, 2011 04:16:17

Was wondering if we could somehow still allow auto render to do stem tracks as well as main master mix as I would find it useful to be able to also have the stems if needed but if this causes to many probe ill just do it the old way :)

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 03, 2011 06:39:03

Hi guys, as usual, thanks for doing this for all of us :)

All actions to load track templates are crashing REAPER now: "Load/apply" and "Load/import", all of them. I'm under WIndows 7 64-bits and tested it in 3.75 and 4.0alpha37, portable.

Here's what the crash log says: http://stashbox.org/1062677/SWSTemplateCrash.png All my track templates are in the TrackTemplates folder and they have their leading numbers, these actions used to work in build 7.

Please let me know if you need more info. Cheers

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 03, 2011 07:24:23

DANG!! Many thanks for the report!

Unfortunately, I can't reproduce here.. Could you post one of those track templates, please ? note: some stuff changed in beta #8 but nothing I can think of about track templates actions.. weird..

Jeff0S commented 10 years ago

From swstim on February 03, 2011 07:41:45

Jeff, do you have an x64 system to test with? If not let me know and I can take a look.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 03, 2011 07:46:22

Thanks Tim!!! I can't see any possible specific x64 issue here.. let's wait for MN trac template example, but yes, of course, your help will be appreciated if I still can't repro!

However, I think to that in between: MN!? sorry to bug you man.. but I had an idea: can you also post the project where applying your track template file example crashes REAPER?

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 03, 2011 08:22:15

Sure, thanks for looking into it :)

I attached it here. It's actually an empty project (but based on my default startup project template), in the zip file I included the track template (it is a 'default track' I use to insert new tracks... it may sound weird but I like to keep all my new tracks at the same height in both tcp and mcp, a height I've defined :) ). Anyways, there you go, please let me know if there's something else I can do.

Attachment: TestProject.zip

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 03, 2011 10:11:33

Thanks A LOT Mercado_Negro, it's so cool to have people like you hanging around. Really!

However, despite all these efforts, dang! I still can't repro. The attached track template and project files are indeed dead simple, it can't be what I had in mind (but I'll improve that anyway). So Tim, yes, I'd appreciate if you could have a look on x64 when you'll have a moment (on a sidenote: I'll do the Win7 x64 switch this month).

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 03, 2011 10:20:22

Thanks again Jeffos for looking into it, hopefully Tim will have some minutes and will check it on his 64-bits machine :)

I'll use Xenakios' actions to load templates in the mean time, these don't crash at all.

Cheers man!

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 03, 2011 12:21:00

Hey, Mercado_Negro! A very last thing (I promise ;-): can you please attach your S&M.ini file here ?

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 03, 2011 13:23:22

ok, I dunno if that's your issue MN (your S&M.ini will help) but I found a very nasty issue, in short S&M.ini file are corrupted since beta #5 ! fix ready other things to check..

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 03, 2011 13:38:00

hmmm that's interesting. I deleted my S&M.ini file this morning because I wanted to get rid of all my FX Chain slots at once. Maybe is this new S&M.ini file that's giving me problems? I attached it here (sorry, I don't have the old one).

Attachment: S&M.ini

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on February 03, 2011 17:21:46

Wanted to say thanks for adding the option to allow stem rendering in the auto render dialogue! ;)

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 04, 2011 01:32:01

Bingo! that's it, your file is corrupted MN (if you're curious: look at the end of the file, there are random data in there and in your case, those random data are some randome RPP file lines..)

Got it, fix coming soon.

Many thanks again MN!

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 04, 2011 03:15:25

Yay! Thanks Jeffos! :)

Jeff0S commented 10 years ago

From swstim on February 04, 2011 19:19:26

!v2.0.0 #9 (February 4, 2011) Autorender: Added global preferences dialog with default render directory option, option to allow stem rendering Fixed crash with new portable installations

Added actions: +"SWS: Toolbar solo toggle" (Note, this replaces "SWS: Are any tracks soloed? [no-op, for toolbar]", please re-add to toolbar) +"SWS: Toolbar arm toggle" +"SWS: Set all sel tracks inputs to match first sel track"

Duplicate recording input check now ignores "input monitoring only" record mode. Fixed possible S&M.ini file corruption (thanks Mercado Negro!)

House cleaning (more to come): +Main menu: Moved all SWS, S&M and Shane extension menu items in the main "Extensions" menu +Main "Extensions" menu filled in alphabetical order (and not strutured by developper anymore)

Summary: SWS/S&M Extension beta (Jan 2011, build #9)

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 04, 2011 20:04:35

Thanks for fixing the problem with Track Templates! :)

I just found a 'corner case' here with Track Templates. If you try to load a template and the slot is empty REAPER crashes. Maybe a warning dialog could prevent this from happening?

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 05, 2011 01:25:26

oh no! not that guy again ^^^ ha ha!

Thanks for the report but can't repro either: did you first deleted your corrupted S&M.ini file ? If yes, can you post the new one and tell me which slot you use?

Also it's not a corner case: when double-clicking or running a slot action on an empty slot, a file browser is displayed so that you can fill that empty slot, then the action is performed.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 05, 2011 04:21:56

ok, go it, fix coming soon (running actions on empty slot is ok but crash confirmed on unexisting slot, example: empty track template list + "load/apply track template, slot 3" = issue ;-). Thanks MN !

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 05, 2011 07:12:30

Oops yes, sorry for not being specific about the unexisting slot and taking it as empty. Thanks for fixing the bug and my crappy report with good info :p

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on February 05, 2011 07:35:19

snapshot window "stealing" focus from keyboard straight after creating a new snapshot

I think this is new as I don't recall having it before but if I create a custom action to save just certain parts of a selected track set as a snapshot then straight after my keyboard can't be used for any normal controls like play etc. The only way to stop this is to go back to the snapshot window and click to un-highlight the last saved snapshot.

(hope that makes sense) ;)

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on February 05, 2011 07:41:14

Ignore above coment_

It was my fault since I was using "new snapshot prompt for name" whilst also having the tick box "prompt for name" on as well so I was getting a double name scenario! ;) sorry

Jeff0S commented 10 years ago

From jacomosi...@gmail.com on February 05, 2011 08:31:31

There's one little menu bug in the extensions menu. When clicking on the Envelope Processor... - the Create Cue Buss from Track Selection menu appears.

Jeff0S commented 10 years ago

From mercadon...@gmail.com on February 05, 2011 08:33:22

"There's one little menu bug in the extensions menu. When clicking on the Envelope Processor... - the Create Cue Buss from Track Selection menu appears."

Confirmed.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 05, 2011 08:57:15

yes, the "Envelope Processor..." menu item that opens the "Create Cue Buss" dialog is already fixed ( r400 ), sorry about that!

Jeff0S commented 10 years ago

From swstim on February 07, 2011 07:39:17

Support for v4 empty take lanes: +S&M build lanes actions now turn "take mosaics" into lanes using v4 empty takes (rather than v3 empty takes) These actions still useful to create take lanes à la v4 from older project saved with "mosaics", for example. +The action "S&M Remove empty take/item among selected items" now also removes v4 empty takes Remark: this action was limited to v3 empty takes before, i.e. takes with empty source +The action "S&M Clear active take/items" now clears takes using v4 empty takes (rather than v3 empty takes). If all takes of an item are empty, the item is removed. Remark: a v4 empty take can be removed thanks to "S&M Cut active take" (removing a given empty take is not possible natively)

Main "Extensions" menu: +Added AW's "Fill gaps..." +Fixed "Envelope Processor..." menu item +(Temporary?) removed "Item/Take" sub-menu (Xenakios actions need to be updated for v4)

Autorender: +Added option to only render tracks with a specified prefix (and optionally remove that prefix from rendered files) +Added global preferences menu +Added option to not prepend track numbers to rendered files +Added limited support to append duplicate numbers to rendered files that would otherwise overwrite each other (This Song(2).mp3) +Added auto-calculation of track pad length (for projects with large numbers of regions to be rendered)

Fixed crash when running some of the S&M Resources view's slot actions (applying, importing, pasting, etc. track templates or FX chains from unexisting slots) Fixed corner case GUI refresh issue in S&M Resources view Issue 250 : Added action "SWS: Toggle auto fades for new items" Added action "SWS: Toolbar mute toggle" Fixed directory scan for grooves on OSX

Summary: SWS/S&M Extension beta (Jan 2011, build #10)

Jeff0S commented 10 years ago

From pend...@gmail.com on February 10, 2011 09:41:58

beta.10

xenakios/sws: load track template ( number )

Doesn't see previous templates numbered higher than 10 in the latest version, reverting to previous beta fixes the problem.

ta

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 10, 2011 10:06:50

confirmed: I removed that! The idea behind was that now you have a better integration in the "Resources" view for that (unlimited numbers of track template slots, import and apply track template actions, etc..). But removing that is a bit straight, I'll put it back. Note: for the same reasons the related actions will be tagged as "[Deprecated]", though

Jeff0S commented 10 years ago

From pend...@gmail.com on February 11, 2011 04:46:29

aah I see.

Hadn't noticed the resources view, looks pretty nifty.

Thanks for all your hard work.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 20, 2011 13:14:34

this actions are back as "deprecated" ( r423 )

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on February 23, 2011 07:42:51

-Jeffos's "find" function (no longer working with empty item notes or markers)--

Hi guys, I can't get the beta version of the "find" window to find empty item notes or markers.

Is it me or is it broken? ;)

ps, also are you still planning to make a "name replace" function? I would pay for that :) (and per track snapshot filtering!) ;)

Jeff0S commented 10 years ago

From swstim on February 23, 2011 07:49:57

MBN,

There's a good chance it's broken.

Search/replace is the top item on my list after SWS v2 is released. (And per track snapshots, too :P)

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 23, 2011 12:34:32

yes, confirmed for "find notes in empty item", I know what going on..

however, all is ok for "find region/markers" here. Please, mbn, can you attach a project showing the issue (and tell me searched string) ?

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 23, 2011 14:27:06

find notes in empty items fixed ( r426 , also changed smthg that was bothering me => faster ;-). thanks for the report, mbn! (waiting for your inputs about markers..)