search

rebecca-123 / m223_team_lovelace

0 stars 0 forks source link

Teacher Review Week 4 #33

Closed rebecca-123 closed 3 years ago

jm1021 commented 3 years ago

Looking at individual commit... Rebecca work is very technical including shifting bits. Very impressive 2/2 Christina made a great video and work is technical as well 2/2 Ritvik technical work is pretty basic, changing image names 1.75/2 William ticket and work don't seem to match. Though I see he made a page 1.75/2.0

Looked at all journals. It would be better if most recent stuff is placed on top. Kind of annoying to scroll all the way down.
Also, I would have one link on README to Issue and then put link(s) on Issue. This way you can make comments and make sure, have multiple links, and make sure thing are in sync.

jm1021 commented 3 years ago

Looking at team accomplishments. The video of scrolling constellations and RGB changes and alternate bulb icons looks great. But, most amazing is your README and the ease I was able to look at your project.
2/2 tam + 1/1 for planning