Closed aednlaxer closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
4d6a26e
) 100.00% compared to head (170ed64
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Found a bug when no accessibility issues found for ToggleButtons
with icons (and perhaps some other form widgets with missing semantic labels). Added a test and fixed the issue in 48c3b60693325435c1bc4d1bee01a8d6333b17fb
Latest change seems to work also with ToggleButtons
This pull request adds a new checker (#4). Input label checker checks if inputs (text fields, checkboxes, radio buttons, switches) have semantic labels.
Example of a failing check:
Example of a passing check:
In the latter example
hint
becomes a semantic label and is visible to screen readers. Text fields may usehint
,labelText
orlabel
and these work fine with the checker which is demonstrated in input_label_checker_test.dartNote: this new checker is on by default
In addition, checkers now have to provide resolution guidance with example on how issues could be fixed (#26).
Closes #4 Closes #26