rebelappstudio / accessibility_tools

MIT License
70 stars 4 forks source link

Fix off-screen check in minimum tap area checker #28

Closed aednlaxer closed 1 year ago

aednlaxer commented 1 year ago

This pull request fixes off-screen node check in minimum tap area checker. Now screen size is compared to node's rectangle to check if node is off-screen. This removes calculations with doubles which were failing in some cases (like in #23).

Closes #23

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (413f928) compared to base (f586b25). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 286 287 +1 ========================================= + Hits 286 287 +1 ``` | [Impacted Files](https://codecov.io/gh/rebelappstudio/accessibility_tools/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rebelappstudio) | Coverage Δ | | |---|---|---| | [lib/src/checkers/checker\_base.dart](https://codecov.io/gh/rebelappstudio/accessibility_tools/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rebelappstudio#diff-bGliL3NyYy9jaGVja2Vycy9jaGVja2VyX2Jhc2UuZGFydA==) | `100.00% <ø> (ø)` | | | [lib/src/checkers/minimum\_tap\_area\_checker.dart](https://codecov.io/gh/rebelappstudio/accessibility_tools/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rebelappstudio#diff-bGliL3NyYy9jaGVja2Vycy9taW5pbXVtX3RhcF9hcmVhX2NoZWNrZXIuZGFydA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rebelappstudio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rebelappstudio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.