rebelappstudio / accessibility_tools

MIT License
67 stars 4 forks source link

Fix off-screen widget check #39

Closed aednlaxer closed 9 months ago

aednlaxer commented 9 months ago

This pull request restores a size check that was replaced by a different check in #28. The off-screen check is now compares node and render object's sizes and node paint bounds.

This fixes an issue when tappable widget is placed in a scrolling container and is partially off-screen (#31)

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (343a966) 100.00% compared to head (a01b2c2) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 343 349 +6 ========================================= + Hits 343 349 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.