search

rebelappstudio / accessibility_tools

MIT License
70 stars 4 forks source link

Create image label checker #48

Closed phcs971 closed 4 months ago

phcs971 commented 5 months ago

Using the same logic for input label checker, created a new image label checker that checks if SemanticFlag isImage is on.

Also works on SvgPicture

Fix #45

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b9291b5) to head (3208c3d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 18 19 +1 Lines 632 645 +13 ========================================= + Hits 632 645 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phcs971 commented 4 months ago

Looks really good, just needs tests and coverage fixed

Fixed!

phcs971 commented 4 months ago

@aednlaxer can we run the CI again, it was an error on publishing the coverage

aednlaxer commented 4 months ago

@aednlaxer can we run the CI again, it was an error on publishing the coverage

Sure thing. However, a rate limit has been reached, I'll take a look at it

phcs971 commented 4 months ago

@aednlaxer can we run the CI again, it was an error on publishing the coverage

Sure thing. However, a rate limit has been reached, I'll take a look at it

I see, might have to wait a little then, time to availability says 22 min