Rebus.Async does not work with Amazon SQS transport

rebus-org / Rebus.Async

:bus: Experimental async extensions for Rebus

https://mookid.dk/category/rebus

Other

13 stars 9 forks source link

Rebus.Async does not work with Amazon SQS transport #6

Closed xhafan closed 4 years ago

xhafan commented 5 years ago

The exception is: Amazon.SQS.Model.InvalidBatchEntryIdException: 'A batch entry id can only contain alphanumeric characters, hyphens and underscores. It can be at most 80 letters long.'

It's caused by ":" character in the message id. Example message id: "request-reply:7e8eefad-bdd7-4914-a5c4-11e684e61fcd". Source code is here.

When I replace the ":" character by "-" character everything works fine for me.

I can create a pull request, please let me know.

mookid8000 commented 5 years ago

Damn! Good catch 👍 PR is most welcome 😄

mookid8000 commented 5 years ago

Hi @xhafan , have you had time to look at this?

xhafan commented 5 years ago

Hi @mookid8000 , sorry didn't have time to look at it yet :( Way too busy :(

mookid8000 commented 4 years ago

I've fixed it now 😄 it's out in Rebus.Async 5.0.1, which should pop up on NuGet.org soon, when their indexing wakes up

Thanks for reporting this issue 😄