search

red-gold / react-social-network

Simple React Social Network
https://medium.com/@qolzam/create-social-network-by-react-js-fe60010a32e6
MIT License
490 stars 484 forks source link

[Enhancement] Upload profile image in background #117

Closed Qolzam closed 5 years ago

Qolzam commented 5 years ago

@Qolzam Thanks for your appreciate, as we discuss above there is need to enhance at the profile image uploading :

  1. We can use the direct image at image upload without waiting for the response and update it in background To generate issue follow : goto profile -> select edit profile -> select photo upload -> then input the photo -> here we can use the direct image uploading in same manner as image uploads at the time of album creation instead of showing loading text with red background. Image uploading screen at profile: Screenshot 2019-05-27 at 6 55 37 PM Image uploading screen at Album: Screenshot 2019-05-27 at 6 58 47 PM Also we discuss about size of profile image at time of uploading screen:
  2. Also, the uploaded image size is not the same as the need to correct them please look at the image uploaded and upload image button, both are with different frame. It will look pity well if they have same size.

Originally posted by @Abhiranjanchaurasia in https://github.com/red-gold/react-social-network/issues/116#issuecomment-496221049

Abhiranjanchaurasia commented 5 years ago

@Qolzam we have created the enhancement regarding the profile image uploading :

  1. We can use the direct image at image upload without waiting for the response and update it in background
  2. The uploaded image size both above are enhanced now
Qolzam commented 5 years ago

@Abhiranjanchaurasia, it's great. However for uploading in background, is there any place or notification to tell user not to close the browser for upload progress.

I would appreciate if you pull request the enhancement, so I can review what you have done.

Thanks a lot! 👍