search

red-gold / react-social-network

Simple React Social Network
https://medium.com/@qolzam/create-social-network-by-react-js-fe60010a32e6
MIT License
489 stars 485 forks source link

Same, translateable application name everywhere #69

Closed KaMeHb-UA closed 6 years ago

Qolzam commented 6 years ago

@KaMeHb-UA I appreciate you contribution. However I'm not sure if it is good idea to set app name in localization file, because it's just a name and not a word for translating. What is your idea?

KaMeHb-UA commented 6 years ago

@Qolzam My idea is very simple: give ability to localize site name. I've seen sites that have name contains translatable parts. This may be very useful, I believe. For example, en: MySocNet es: MiRedSoc How do you think?

KaMeHb-UA commented 6 years ago

Ok, my bad. I think, this is not necessary. But look to src/containers/master/MasterComponent.tsx:128:24, there is "hard"-defined title. Fix it, please