red-gold / react-social-network

Simple React Social Network
https://medium.com/@qolzam/create-social-network-by-react-js-fe60010a32e6
MIT License
489 stars 485 forks source link

[Discussion] Database optimization #79

Open KaMeHb-UA opened 6 years ago

KaMeHb-UA commented 6 years ago

There is few questions: Comments duplicates in posts.. Is it really needed? Why shoud it be if client can query comments from /comments collection with sort and limit? User data in posts and comments data. This is overingeneering, I think. Can client write only own id? This may be more scalable solution if there is no need to get all the comments with all the user data, isn't it?

Qolzam commented 6 years ago

@KaMeHb-UA Thanks for your questions. Sure there are more ways to optimize. Not only comments also posts and users, etc. However there are so many details need to be covered which is impossible with my narrow time. Not sure why people only want to to work and start the project again by themselves, instead of contributing like a team work so we can cover more features and optimizations.

Anyway, I expect for version alpha-1 to have search engine with Algolia, sms notification, email notifications, chat, data optimization, security extensions and other improvements. These are done but there is problem that for new version I need to go on on Firebase Pricing Plan which cost to show demo for users. I have to get support or set limitation for number of requests. I hope I can do that soon.

KaMeHb-UA commented 6 years ago

Unfortunately, I (for now) can't help with optimizations because of I don't know TS, so now I writing live chat system in pure JS (wait for contributing😀)

KaMeHb-UA commented 6 years ago

@Qolzam Will be able I to contribute pure JS code?

Qolzam commented 6 years ago

@KaMeHb-UA I really appreciate your contribution as always 😀 👍 . There is no different between TS and JS. only type that make the job easier and faster. In my opinion you need one or two days to get basic TS and it's enough for start.