redhat-nfvpe / kube-ansible

Spin up a Kubernetes development environment
Apache License 2.0
123 stars 54 forks source link

[cleanup] Confusing naming convention for bridges #154

Open dougbtv opened 6 years ago

dougbtv commented 6 years ago

While running through some of the Multus CRD stuff, I realized I had made some mistakes due to a wonky naming scheme for the bridges.

bridge_name: br0
bridge_network_name: "br0"

I think that having two different variables here is actually good -- because sometimes you want to create the bridge on the virthost, and optionally use it -- or not. E.g. sometimes you'd create br0 (via bridge_network_name) on the virthost, and then you'd actually specify virbr0 (via bridge_name) to have NAT'd VMs on the virthost, sometimes at least.

In the end, these should maybe get named, or, note here for if/when the virthost plays get broken out otherwise.

leifmadsen commented 6 years ago

hrmmm.... how about...

?