search

redhat-openshift / acm-submariner-tester

1 stars 0 forks source link

Fixes for Ginkgo tests, MCE, and UMB #73

Closed manosnoam closed 2 years ago

redhat-openshift commented 2 years ago

Good question, Since in Ginkgo 2 the flags to set junit file have changed, I've added the file twice, so in this case it will be generated both for ginkgo 1 (with submariner 0.11) and for ginkgo 2 (with submariner 0.12.1).

According to my check, there is no error if calling it twice. But if you think of better way of backward compatibility let me know.

On Thursday, May 12, 2022, Maxim Babushkin @.***> wrote:

@MaxBab commented on this pull request.

In test_functions:

@@ -4078,25 +4081,31 @@ function test_project_e2e_with_go() { msg="# Junit report file will be created: \n# $junit_output_file \n" echo -e "$msg" echo -e "$msg" >> "$E2E_LOG"

  • junit_params=("-ginkgo.reportFile" "$junit_output_file")
  • junit_params=("-ginkgo.reportFile" "$junit_output_file" "-ginkgo.junitReport" "$junit_output_file")

Do you need to specify the "$junit_output_file" twice? Once before and once after the ginkgo argument?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.< https://ci4.googleusercontent.com/proxy/SVM1k6njqhzlRXsnKnYhUzTGimXYRYQdxkpWL6SyE3M3HGX06G7YNeCgiECCxcfb7nqoeaEzXoMwj-iKsA0WL4lIaMg_wQlXOxUPt3VswPYPV64VymA6sKqQfU4rklO8ZVhvOuwEsRHYDHaQoygNOvPb_C5ugR1DRxoJVKma0vcpGN1R5OUh8kn20Wr4HfknzxJGNh50yvBvqGtUKD0IXJYbM4eOzv7WmVq6gN-JaelBdtd9NIat=s0-d-e1-ft#https://github.com/notifications/beacon/AUNF5GYSMDATNGYNEP7JVJLVJUUU7A5CNFSM5VVT5H6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHHRDQQI.gif>Message ID: <redhat-openshift/acm-submariner-tester/pull/73/review/ @.***>

MaxBab commented 2 years ago

Good question, Since in Ginkgo 2 the flags to set junit file have changed, I've added the file twice, so in this case it will be generated both for ginkgo 1 (with submariner 0.11) and for ginkgo 2 (with submariner 0.12.1). According to my check, there is no error if calling it twice. But if you think of better way of backward compatibility let me know. On Thursday, May 12, 2022, Maxim Babushkin @.> wrote: @MaxBab commented on this pull request. ____ In test_functions: > @@ -4078,25 +4081,31 @@ function test_project_e2e_with_go() { msg="# Junit report file will be created: \n# $junit_output_file \n" echo -e "$msg" echo -e "$msg" >> "$E2E_LOG" - junit_params=("-ginkgo.reportFile" "$junit_output_file") + junit_params=("-ginkgo.reportFile" "$junit_output_file" "-ginkgo.junitReport" "$junit_output_file") Do you need to specify the "$junit_output_file" twice? Once before and once after the ginkgo argument? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.< https://ci4.googleusercontent.com/proxy/SVM1k6njqhzlRXsnKnYhUzTGimXYRYQdxkpWL6SyE3M3HGX06G7YNeCgiECCxcfb7nqoeaEzXoMwj-iKsA0WL4lIaMg_wQlXOxUPt3VswPYPV64VymA6sKqQfU4rklO8ZVhvOuwEsRHYDHaQoygNOvPb_C5ugR1DRxoJVKma0vcpGN1R5OUh8kn20Wr4HfknzxJGNh50yvBvqGtUKD0IXJYbM4eOzv7WmVq6gN-JaelBdtd9NIat=s0-d-e1-ft#https://github.com/notifications/beacon/AUNF5GYSMDATNGYNEP7JVJLVJUUU7A5CNFSM5VVT5H6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHHRDQQI.gif>Message ID: <redhat-openshift/acm-submariner-tester/pull/73/review/ @.>

If it works, not a big deal.