reevoo / samuel

That is a tasty pull request.
Other
4 stars 0 forks source link

[+@richardbatty] Fixed full_name key on repository for HasComments #34

Closed jonnyarnold closed 9 years ago

jonnyarnold commented 9 years ago

The HasComments check was not working properly because the key specified never existed.

reevoo-samuel commented 9 years ago

_If you're new, read the guidelines._

Good code is tested, easy to understand and able to cope when things go wrong.

Good pull requests are descriptive, small and short-lived.

lpil commented 9 years ago

That's interesting. Jonny opened this, but it's Richard's code, and he's merged without comment from anyone else.

That should be guarded against.