Moan about old Pull Requests

[jonnyarnold]

When mix do app.start, daily_checks is run, Samuel will look at all open Pull Requests. If the number of days the PR has been open is divisible by 7 (and isn't 0), Samuel will comment.

This should work with Heroku Scheduler.

[reevoo-samuel]

_If you're new, read the guidelines._

Good code is tested, designed for change, easy to understand and able to cope when things go wrong.

Good pull requests are descriptive, small and short-lived.

For the Author

• [x] Description explains what you have done and why.
• [x] Tests have been written (or you have explained why you don't need tests).
• [x] Documentation/comments have been added/updated.

For the Reviewer

• [ ] The code is well-designed and able to cope with change.
• [ ] The code is easy to understand.
• [ ] Tests cover happy and unhappy paths in the code.
• [ ] Tests are green on CI (or pulled/tested on your machine).

[lpil]

I feel like I want to try and re-write this app, it all feels a bit coupled to the web component, which should really just be a plugin the rest of the app is blind to.

[lpil]

But yeah, ship it

[jonnyarnold]

I agree with you that it would be good to have another go at this.

SHIPPING ANYWAY

[lpil]

In the spirit of Samuel we are ignoring all content of the review and hitting that merge button ;)

[jonnyarnold]