reinforced / Reinforced.Typings

Converts C# classes to TypeScript interfaces (and many more) within project build. 0-dependency, minimal, gluten-free
MIT License
507 stars 82 forks source link

feat: Net8 support #264

Closed JohnCampionJr closed 11 months ago

JohnCampionJr commented 1 year ago

I know net8.0 is currently in preview status, but it'd be nice if RT would go ahead and support it since its a pretty straightforward change.

lukedukeus commented 1 year ago

+1, opened PR: #265

KennethHoff commented 1 year ago

I just came to this repo to do just this; Prematurely mention this should be updated.

maberalc commented 1 year ago

I see this PR is merged, but there is no new version since 6 months ago. I guess it will be updated just when .NET 8 releases, but i could be released as preview too. Anyway, how could I try to compile and use it on my tests on .NET 8? I tried to use it in my project after using it on another .NET 7 project but it is not working.

KennethHoff commented 1 year ago

@pavel-b-novikov Would be nice if you could release a new version so we can test! 👍

maberalc commented 1 year ago

No news on the preview? Or just wait for final .NET 8 release?

iotalambda commented 1 year ago

I needed this for my .NET 8 project today, so I built the nuget myself and added it to a feed within my project https://github.com/iotalambda/Reinforced.Typings :/

lindsve commented 1 year ago

Any chance for an updated package now that .NET is officially released?

pavel-b-novikov commented 1 year ago

Yes. I took decision not to issue updates for all the previews. Otherwise I'd have to quit job and publish package every week :)

Redlab1 commented 12 months ago

Hi @pavel-b-novikov, do you have an ETA on when you'll be releasing the new version?

jeremy-allocate commented 11 months ago

Hello! Dotnet 8 has been officially released and the lack of a corresponding update here is blocking our upgrade. Is there an ETA on a new release here @pavel-b-novikov?

pavel-b-novikov commented 11 months ago

Will handle within a week

Redlab1 commented 11 months ago

Could you make this more bulletproof for new .net versions? When a new .net version comes out, this shouldnt be blocking us from updating our solutions.

We're considering merging away from this package due to this reason. Many packages work seemlessly for all .NET5+ versions, what makes this package not compatible with newer .NET versions?

jeremy-allocate commented 11 months ago

Could you make this more bulletproof for new .net versions? When a new .net version comes out, this shouldnt be blocking us from updating our solutions.

We're considering merging away from this package due to this reason. Many packages work seemlessly for all .NET5+ versions, what makes this package not compatible with newer .NET versions?

Here was the commit from back in August that added dotnet 8 support: https://github.com/reinforced/Reinforced.Typings/commit/c9e98575f0b27fe91f31e297bb1bc2ff4078c0e0

Redlab1 commented 11 months ago

@jeremy-allocate Yeah I know, but why is it hardcoding the .net versions that it's supporting? Also, why doest it take so long to make a new release when the only difference is some new hardcoded values? It should take 1 minute to create a new release with those changes.

smkanadl commented 11 months ago

@Redlab1 I can understand the frustration here, but please bear in mind that this piece of (very) valuable software is free for you to use and maintained by @pavel-b-novikov in his spare/free time.

I've had a very quick look into this topic last year and I think the reason is the rtcli tool that is loaded and executed by the dotnet cli / msbuild. And differences in the framework have caused me some trouble with dependency resolution.

JohnCampionJr commented 11 months ago

Might also be less maintenance if the older deprecated versions of .NET were removed. Make this a breaking v2.0 and only support NET6.0, NET8.0, NETSTANDARD2.0

smkanadl commented 11 months ago

@JohnCampionJr that would (for me) make only sense if I could still target a net7.0 application. But I am not sure if that is technically possible (without rewriting the whole msbuild integration.

JohnCampionJr commented 11 months ago

@JohnCampionJr that would (for me) make only sense if I could still target a net7.0 application. But I am not sure if that is technically possible (without rewriting the whole msbuild integration.

Yeah, I forgot 7.0 is still under official support until May 2024. So it should stay; but its ultimately up to @pavel-b-novikov not me :)

pavel-b-novikov commented 11 months ago

I prefer not to remove any of supported .net platforms to avoid breaking changes for people who depend on RT, but use legacy .net stack. For me it costs 0, but for end users it may cost significantly more

pavel-b-novikov commented 11 months ago

@jeremy-allocate why doest it take so long to make a new release when the only difference is some new hardcoded values?

Because of context switches. RT is not my full-time and not my 1st priority unfortunately

jeremy-allocate commented 11 months ago

Renovate just informed me that v1.6.3 has been posted and is available via nuget. Tested on my dotnet 8 branch and things look good, thanks @pavel-b-novikov!

JohnCampionJr commented 11 months ago

Thank you @pavel-b-novikov !!

pavel-b-novikov commented 11 months ago

You are welcome. Sorry for delay

Redlab1 commented 11 months ago

Thank you @pavel-b-novikov, appreciate your efforts. 🥇