relaton / relaton-nist

NistBib: retrieve NIST Standards for bibliographic use using the BibliographicItem model
https://www.metanorma.com
MIT License
2 stars 1 forks source link

Rendering of NIST White Paper reference, always prioritize fetching final instead of draft #19

Closed ronaldtse closed 5 years ago

ronaldtse commented 5 years ago

Using the following reference item:

* [[[NISTCSF11,NIST Framework for Improving Critical Infrastructure Cybersecurity Version 1.1]]], _NIST Framework for Improving Critical Infrastructure Cybersecurity Version 1.1_
  1. The document type is rendering in lowercase "nist" instead of "NIST"
  2. It's getting the 2nd Draft rather than the final.
Screen Shot 2019-05-27 at 10 37 48 PM

Originally posted by @ronaldtse in https://github.com/metanorma/relaton-nist/issues/17#issuecomment-496233868

opoudjis commented 5 years ago

The two are completely different issues. Fetching the 2nd draft remains an issue here. The prefixing of "nist" is a separate issue: https://github.com/metanorma/metanorma-nist/issues/124

(though it too will need to be propagated into relaton-nist)

ronaldtse commented 5 years ago

@andrew2net also, the "type" is wrong -- this is a "white-paper" not a "standard". See the Relaton XML cache attached.

nist_framework_for_improving_critical_infrastructure_cybersecurity_version_1.1.xml.zip

opoudjis commented 5 years ago

Ronald, you're behind.

bibitem@type is now "standard" for all of Relaton. That is because document types are idiosyncratic to each flavour, so we cannot get a single grammar to specify all the possible enums.

The document type for a specific standard subclass is bibdata/ext/doctype.

If the document type is going to be referenced in a citation, it must NOT be modelled as document type. It must be modelled as a series.

opoudjis commented 5 years ago

Note that #124 has also fixed this so that "White Paper" is populated in ext/doctype, which was the other issue raised here.

ronaldtse commented 5 years ago

@opoudjis just to confirm, is @andrew2net going to take care of this?

andrew2net commented 5 years ago

@ronaldtse I'm going but have a lot of tasks. Feel free to prioritize tasks in my todo and in progress lists.

ronaldtse commented 5 years ago

@andrew2net already done :wink:

opoudjis commented 5 years ago

Yes, I wasn't offering to take this one on.

Priority remains relaton. There's some instability still in the gems, I'm seeing that in metanorma-gb rpsec, <gbtype> etc are still being returned in rspec from relaton: in bib_retval the obsolete elements are not being rendered to XML, but in fetch_ref they are.