search

relaton / relaton-nist

NistBib: retrieve NIST Standards for bibliographic use using the BibliographicItem model
https://www.metanorma.com
MIT License
2 stars 1 forks source link

Travis for relaton-nist and relaton failing on VCR #25

Closed opoudjis closed 5 years ago

opoudjis commented 5 years ago

https://travis-ci.com/metanorma/relaton-nist/jobs/208319499

An HTTP request has been made that VCR does not know how to handle:
  GET https://csrc.nist.gov/publications/detail/white-paper/2018/04/16/cybersecurity-framework-v11/final
opoudjis commented 5 years ago

Also failing for relaton Travis:

https://travis-ci.org/metanorma/relaton/jobs/546092095

An HTTP request has been made that VCR does not know how to handle:
  GET https://csrc.nist.gov/publications/detail/fips/140/1/archive/1994-01-11

The fail seems to be specific to Linux rather than OSX.

andrew2net commented 5 years ago

@opoudjis fixed, but it needs to be rereleased. There is sorting of hits by status in this gem. But if statuses are equal then result different for Linux and Mac. For White Papers, we need to add sorting by relevance. I've also added a release date to sorting function.

opoudjis commented 5 years ago

I'd rather wait until the next regular release, in a week or two, unless this is mission-critical. @ronaldtse?

andrew2net commented 5 years ago

@opoudjis it needs more work with sorting. In some cases, it doesn't work correctly.

andrew2net commented 5 years ago

@opoudjis fixed relevant sorting. I think we need to release these last changes because of it influent on White Pages search. White Pages don't have code so we can't filter hits by code. I added function to sort hits by most relevant titles.

ronaldtse commented 5 years ago

Yes, it's been released yesterday, I confirm that it works. Thanks!